From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Juergen Gross" <jgross@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Ian Jackson" <iwj@xenproject.org>
Subject: Re: [PATCH 3/3] tools/libs: Fix headers.chk logic
Date: Fri, 5 Mar 2021 13:38:35 +0000 [thread overview]
Message-ID: <291c999a-19aa-2863-8154-4acc1774b4b8@citrix.com> (raw)
In-Reply-To: <20210305124949.6719-4-andrew.cooper3@citrix.com>
On 05/03/2021 12:49, Andrew Cooper wrote:
> c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk
> rule, without replacing it.
>
> As headers.chk uses $^, a typical build looks like:
>
> andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/
> make: Entering directory '/local/xen.git/tools/libs/devicemodel'
> for i in ; do \
> gcc -x c -ansi -Wall -Werror
> -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \
> -S -o /dev/null $i || exit 1; \
> echo $i; \
> done >headers.chk.new
> mv headers.chk.new headers.chk
>
> i.e. with an empty for loop, and checking only the $(AUTOINCS).
>
> Reinsert a $(LIBHEADERS) dependency.
>
> Fixes: 4664034cd ("tools/libs: move official headers to common directory")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Juergen Gross <jgross@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
Apologies - I totally messed up the CC list here.
For 4.15. Regression from 4.14, in some build-time checking logic.
~Andrew
> ---
> tools/libs/libs.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
> index a68cec244c..2d973ccb95 100644
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -76,7 +76,7 @@ else
> .PHONY: headers.chk
> endif
>
> -headers.chk: $(AUTOINCS)
> +headers.chk: $(LIBHEADERS) $(AUTOINCS)
>
> headers.lst: FORCE
> @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp
next prev parent reply other threads:[~2021-03-05 13:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:49 [PATCH for-4.15 0/3] tools/libs: Multiple fixes to header handling Andrew Cooper
2021-03-05 12:49 ` [PATCH 1/3] tools/libxentoolcore: Fill in LIBHEADERS Andrew Cooper
2021-03-05 13:25 ` Ian Jackson
2021-03-11 13:37 ` Jürgen Groß
2021-03-05 12:49 ` [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API Andrew Cooper
2021-03-05 13:26 ` Ian Jackson
2021-03-05 13:53 ` Jan Beulich
2021-03-05 14:12 ` Andrew Cooper
2021-03-05 14:18 ` Jan Beulich
2021-03-05 14:21 ` Jan Beulich
2021-03-05 15:13 ` Andrew Cooper
2021-03-05 15:20 ` Ian Jackson
2021-03-05 14:28 ` Ian Jackson
2021-03-05 12:49 ` [PATCH 3/3] tools/libs: Fix headers.chk logic Andrew Cooper
2021-03-05 13:38 ` Andrew Cooper [this message]
2021-03-05 13:43 ` Ian Jackson
2021-03-11 13:38 ` Jürgen Groß
2021-03-11 13:28 ` Ping [PATCH for-4.15 0/3] tools/libs: Multiple fixes to header handling Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=291c999a-19aa-2863-8154-4acc1774b4b8@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).