Re: [Xen-devel] [livepatch: independ. modules v2 2/3] livepatch: Allow to override inter-modules buildid dependency

From: "Wieczorkiewicz, Pawel" <wipawel@amazon.de>
To: Julien Grall <julien.grall@arm.com>
Cc: Tim Deegan <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	"Pohlack, Martin" <mpohlack@amazon.de>,
	"Wieczorkiewicz, Pawel" <wipawel@amazon.de>,
	Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [livepatch: independ. modules v2 2/3] livepatch: Allow to override inter-modules buildid dependency
Date: Tue, 20 Aug 2019 14:52:31 +0000	[thread overview]
Message-ID: <2BE73DB1-9C24-4728-AC08-4A3C5E4187F6@amazon.com> (raw)
In-Reply-To: <c6b76dbd-bf18-aa66-0e55-84b9adedb45a@arm.com>

> On 20. Aug 2019, at 16:28, Julien Grall <julien.grall@arm.com> wrote:
> 
> Hi,
> 
>>> 
…snip...
>> Yeah, since I got feedback and reviews on various patches that I have already submitted the way I did,
>> I simply continue with what I have until all comments are addressed (I do not want to lose anything).
> 
> What do you mean by "all comments are addressed"? Usually you gather a set of comments for a series, address them and then resend the series with all of them addressed.
> 

Yeah, but people invested time in reviews and replied to my incorrectly sent threads, so I find it rude to ignore such comments and start a new thread instead.
But if this is the recommended practice, I will obey.

>> Then, I will re-send the patches in 2 series: livepatch-build-tools and xen with all changes,
>> Reviewed-by/Acked-by and cover letters. This is the way recommended by Andrew.
> 
> Please don't send the patch one by one to check if everyone is happy. Just resend all of them in one go once you gathered enough feedback.
> 

Ok.

>> Unfortunately, it will be also quite confusing I think, because various changes belonging to different topics,
>> are distributed between those 2 distinct repos.
> 
> That also happen when you have multiple patches in a series. Feature implemented accross multiple patch needs a place to discuss. This can usually be done in the cover letter. For multi repo series, you can steer the discussion on a single repo and just replicate the changes in the other one once there are an agreement.

Fine. Let me then send the 2 full series for each repo with all the changes and corresponding cover letters.

> 
> Cheers,
> 
> -- 
> Julien Grall

Best Regards,
Pawel Wieczorkiewicz

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel