From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B30C433E1 for ; Mon, 3 Aug 2020 15:53:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50A6F2076C for ; Mon, 3 Aug 2020 15:53:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A6F2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cm6-0002QP-Tt; Mon, 03 Aug 2020 15:53:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2cm5-0002QK-6g for xen-devel@lists.xenproject.org; Mon, 03 Aug 2020 15:53:17 +0000 X-Inumbo-ID: 70fc0b2e-d5a1-11ea-af4f-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 70fc0b2e-d5a1-11ea-af4f-12813bfff9fa; Mon, 03 Aug 2020 15:53:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id ED53EB02A; Mon, 3 Aug 2020 15:53:29 +0000 (UTC) Subject: Re: [PATCH v3 01/11] x86/iommu: re-arrange arch_iommu to separate common fields... To: Paul Durrant References: <20200803122914.2259-1-paul@xen.org> <20200803122914.2259-2-paul@xen.org> From: Jan Beulich Message-ID: <2a5a0a65-81aa-2c1f-c98a-5e6fd54ba3df@suse.com> Date: Mon, 3 Aug 2020 17:53:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803122914.2259-2-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Wei Liu , Andrew Cooper , Paul Durrant , Lukasz Hawrylko , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 14:29, Paul Durrant wrote: > From: Paul Durrant > > ... from those specific to VT-d or AMD IOMMU, and put the latter in a union. > > There is no functional change in this patch, although the initialization of > the 'mapped_rmrrs' list occurs slightly later in iommu_domain_init() since > it is now done (correctly) in VT-d specific code rather than in general x86 > code. > > NOTE: I have not combined the AMD IOMMU 'root_table' and VT-d 'pgd_maddr' > fields even though they perform essentially the same function. The > concept of 'root table' in the VT-d code is different from that in the > AMD code so attempting to use a common name will probably only serve > to confuse the reader. > > Signed-off-by: Paul Durrant Acked-by: Jan Beulich with a remark (can be taken care of while committing if no other need for a v4 arises): > @@ -598,11 +600,12 @@ static void amd_dump_p2m_table(struct domain *d) > { > const struct domain_iommu *hd = dom_iommu(d); > > - if ( !hd->arch.root_table ) > + if ( !hd->arch.amd.root_table ) > return; > > - printk("p2m table has %d levels\n", hd->arch.paging_mode); > - amd_dump_p2m_table_level(hd->arch.root_table, hd->arch.paging_mode, 0, 0); > + printk("p2m table has %d levels\n", hd->arch.amd.paging_mode); > + amd_dump_p2m_table_level(hd->arch.amd.root_table, > + hd->arch.amd.paging_mode, 0, 0); At least where you touch the format string anyway, converting %d to %u where you converted fron plain int to unsigned int would be nice. Jan