From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Bird Subject: Re: [PATCH] tools/hotplug: Add native systemd xendriverdomain.service Date: Thu, 07 Jul 2016 14:19:00 +0000 Message-ID: <2adeb0de-a2b4-e85e-e826-0f91c075fb4b@openmailbox.org> References: <1467516781-12830-1-git-send-email-rustybird@openmailbox.org> <20160707120436.GL416@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4955262418785833900==" Return-path: In-Reply-To: <20160707120436.GL416@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xen.org Cc: Wei Liu List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4955262418785833900== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n7Ur9hSJLfQaeHxEBCI5M4jeuEHALJIoj" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n7Ur9hSJLfQaeHxEBCI5M4jeuEHALJIoj Content-Type: multipart/mixed; boundary="Q7rVsCtsTiOal7uWXktKMbtn4W0VmdkrN" From: Rusty Bird To: xen-devel@lists.xen.org Cc: Wei Liu Message-ID: <2adeb0de-a2b4-e85e-e826-0f91c075fb4b@openmailbox.org> Subject: Re: [Xen-devel] [PATCH] tools/hotplug: Add native systemd xendriverdomain.service References: <1467516781-12830-1-git-send-email-rustybird@openmailbox.org> <20160707120436.GL416@citrix.com> In-Reply-To: <20160707120436.GL416@citrix.com> --Q7rVsCtsTiOal7uWXktKMbtn4W0VmdkrN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Wei Liu: > While I understand it might be necessary to have a dedicated service > file for xendriverdomain, I can't seem to be able to figure out the > rationale from the commit message. >=20 > After thinking a bit harder, may I suggest commit message like this (an= d > please correct me if I'm wrong): >=20 > We need to have a dedicated service for xendriverdoamin in driver > domain. This patch creates a service file for it. This service is only > relevant to DomU. >=20 > The service file uses ConditionVirtualization=3Dxen becuase that evalua= tes > to false in Dom0 while true in DomU, so that we only starts this servic= e > in DomU. Thanks for the feedback! I've sent a v2 patch with a less cryptic commit message that incorporates this information. Rusty --Q7rVsCtsTiOal7uWXktKMbtn4W0VmdkrN-- --n7Ur9hSJLfQaeHxEBCI5M4jeuEHALJIoj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJXfmUOXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4NEI1OUJDRkM2MkIxMjlGRTFCMDZEMDQ0 NjlENzhGNDdBQUYyQURGAAoJEEadePR6ryrfnxsQAIeqWpNZ/vQ2l+9qwFWQ0vEf ndpUsaK5TYlF674cL/tc8gUCGHyKWblR9oLRXFvMi4csCue3U6BMJKr2XcN8rCTx ZE9WG27WBbmL2zHTxPafh91A+DCjkC0EpEzpkhfj0mGW/WSh7/nMNFe1PV7NkxaL HzGzAZyERZSdDH4X2RZhbwG0F476QM5s8ddZuy0Id2DIQt9lwXc/YGYi5PeQy0v1 m5LEsN3piFlzF848KRsLUOorTZqz4ShKeZ6ZNePMQB34YoDarC3wGQGrayy482zQ ad2TwoC6FpP7deqCp2igTEKt1Knhch7ZYd0xLGgbkLAliaYcGO26Fv4GZa+N5hxr IQZz8FZUv0uF5Xup+VFdNT109sB5h5wdobjBil07UUtfPxMubqzVoyQ8+DOa+Pu2 2A6mlv5ikOSUIis2jvh5j8v6kzCj5ACUpQ+LfyrrW1Wj6Qp//WMV+M6qXGkwjsmY pH9VYpOlNQgUfJTsFTnHS+gxD5UcpDGrnirgj1NUriMu3nLQsei5LikaQvcKoouf UOqMTx2UJxlIwnYMgRSSCmKmvihPf6GfDARU1aclJ43WoDgf5nu86m3eJsf+KbhX tkT78E6D7HQtMoeYwMTCms8iPkO0INkJTBOIIoXjx4JuIdy26+5fbAxCHJYtYSsd /oTOezKoSms3QlKi9Yt+ =NR5N -----END PGP SIGNATURE----- --n7Ur9hSJLfQaeHxEBCI5M4jeuEHALJIoj-- --===============4955262418785833900== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4955262418785833900==--