From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Paul Durrant <paul@xen.org>, <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <pdurrant@amazon.com>,
Eslam Elnikety <elnikety@amazon.com>,
Christian Lindig <christian.lindig@citrix.com>,
David Scott <dave@recoil.org>, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v4 1/3] domctl: introduce a new domain create flag, XEN_DOMCTL_CDF_disable_fifo, ...
Date: Wed, 25 Nov 2020 11:30:41 +0000 [thread overview]
Message-ID: <2b2e3737-ecd7-907f-3c72-f31835dc5cb8@citrix.com> (raw)
In-Reply-To: <20201124191751.11472-2-paul@xen.org>
On 24/11/2020 19:17, Paul Durrant wrote:
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 666aeb71bf1b..70701c59d053 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -70,9 +70,11 @@ struct xen_domctl_createdomain {
> #define XEN_DOMCTL_CDF_iommu (1U<<_XEN_DOMCTL_CDF_iommu)
> #define _XEN_DOMCTL_CDF_nested_virt 6
> #define XEN_DOMCTL_CDF_nested_virt (1U << _XEN_DOMCTL_CDF_nested_virt)
> +#define _XEN_DOMCTL_CDF_disable_fifo 7
> +#define XEN_DOMCTL_CDF_disable_fifo (1U << _XEN_DOMCTL_CDF_disable_fifo)
The sense is backwards. It should be a "permit the use of FIFO"
control. If the code had been written this way to begin with, the bug
you found wouldn't have existed.
Given that there is not currently a way to disable FIFO, you can
probably do without an enumeration of whether the hypervisor supports it
or not.
~Andrew
next prev parent reply other threads:[~2020-11-25 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 19:17 [PATCH v4 0/3] evtchn: Introduce a per-guest knob to control FIFO ABI Paul Durrant
2020-11-24 19:17 ` [PATCH v4 1/3] domctl: introduce a new domain create flag, XEN_DOMCTL_CDF_disable_fifo, Paul Durrant
2020-11-25 9:20 ` Jan Beulich
2020-11-25 9:36 ` Jan Beulich
2020-11-25 11:01 ` Durrant, Paul
2020-11-25 11:10 ` Paul Durrant
2020-11-25 11:51 ` Jan Beulich
2020-11-25 12:10 ` Durrant, Paul
2020-11-25 11:30 ` Andrew Cooper [this message]
2020-11-25 11:49 ` Durrant, Paul
2020-11-24 19:17 ` [PATCH v4 2/3] libxl: add a 'disable_fifo_evtchn' flag to libxl_domain_build_info Paul Durrant
2020-11-24 19:17 ` [PATCH v4 3/3] xl: add 'disable_evtchn_fifo' boolean option into xl.cfg(5) Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b2e3737-ecd7-907f-3c72-f31835dc5cb8@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=elnikety@amazon.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).