From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC88C432C1 for ; Tue, 24 Sep 2019 14:14:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A74A22064A for ; Tue, 24 Sep 2019 14:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A74A22064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iClaV-0006f9-IK; Tue, 24 Sep 2019 14:14:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iClaU-0006ev-0v for xen-devel@lists.xenproject.org; Tue, 24 Sep 2019 14:14:42 +0000 X-Inumbo-ID: a5f3d050-ded5-11e9-8628-bc764e2007e4 Received: from mx1.suse.de (unknown [195.135.220.15]) by localhost (Halon) with ESMTPS id a5f3d050-ded5-11e9-8628-bc764e2007e4; Tue, 24 Sep 2019 14:14:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EF064ACA5; Tue, 24 Sep 2019 14:14:39 +0000 (UTC) Message-ID: <2b764dc0bb33da125423042e7a59bb8e03d95ea4.camel@suse.com> From: Dario Faggioli To: Juergen Gross , xen-devel@lists.xenproject.org Date: Tue, 24 Sep 2019 16:14:38 +0200 In-Reply-To: <20190914051944.21409-3-jgross@suse.com> References: <20190914051944.21409-1-jgross@suse.com> <20190914051944.21409-3-jgross@suse.com> Organization: SUSE User-Agent: Evolution 3.32.4 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v4 2/4] xen/sched: remove cpu from pool0 before removing it X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Tim Deegan , Julien Grall , Jan Beulich , Ian Jackson Content-Type: multipart/mixed; boundary="===============7965391237782979236==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============7965391237782979236== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-SfVF0XFNgk1q7/GEpawK" --=-SfVF0XFNgk1q7/GEpawK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2019-09-14 at 07:19 +0200, Juergen Gross wrote: > Today a cpu which is removed from the system is taken directly from > Pool0 to the offline state. This will conflict with the new idle > scheduler, so remove it from Pool0 first. Additionally accept > removing > a free cpu instead of requiring it to be in Pool0. >=20 > For the resume failed case we need to call the scheduler code for > that > situation after the cpupool handling, so move the scheduler code into > a function and call it from cpupool_cpu_remove_forced() and remove > the > CPU_RESUME_FAILED case from cpu_schedule_callback(). >=20 > Note that we are calling now schedule_cpu_switch() in stop_machine > context so we need to switch from spinlock_irq to spinlock_irqsave. >=20 > Signed-off-by: Juergen Gross > --- > V2: rename cpupool_unassign_cpu_[epi|pro]logue() (Dario Faggioli) > V4: fix bug when unassigning cpu not in pool > Reviewed-and-Tested-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-SfVF0XFNgk1q7/GEpawK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl2KJM4ACgkQFkJ4iaW4 c+6ZdQ//e6PIL28hcbDzB265aglBZP8Sr7zYS4jl5Q7NkRa4HIGZjgfyaVCZ6Nrz I4otpgxe2egStrHX+F1dEcrVckBl+MyolfY+mWhUnmNoidnKrEk4JaRe+QrxoSrY m7MxzQktgqa/wTvMoWa4ocMnKnWIuGVbb0vCFX8kRLgx6w0e9fnVZmjafGf+vyi4 m2nowat3YGKDeJdMNxKpmnfDOgJMRVbfQv+ih0c+NWS1n3WsUl2IUdjeCYrVZDo+ aIqmHpsE+XzyinVH9F/HBuohj0EZNZyfhccC3EbEUvdCTHfU1MSQasGuFb2noAEG bOEE4pvDcjxmPokWT0njX/aAT89dbReyRF6MyoX/EvFcB6TcoJp0F0qSkI9j3VGk HCHqiDlYh5FH4kxf3QTS7A88B20NRKMlyrv28ynN4GPo4efihx5FWkyhusFpHrOn 5d1kFJzwS/x1XiO2UfNgrogwZQbe17Y883lU2yrpU8wo4QLo9eoE9IcDd2hdA00K KD7BkjvFILE9TgKEDTlX+y3HgfTUJ6H0q6FNzSwtqhhhgotKScEHZRgHdAW0i6IU tsQscwjRXtkO7MlyMKaMYWcYkhTdwH3JHliVDJGScVfDvPFp/gKrSRcusbFqQXRH NjF3/AWfeLyD40n/afohs/VVNqDDov45N9KzJsV0ql/LnV0ixo4= =TrGE -----END PGP SIGNATURE----- --=-SfVF0XFNgk1q7/GEpawK-- --===============7965391237782979236== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============7965391237782979236==--