Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Lars Kurth <lars.kurth@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"Tim \(Xen.org\)" <tim@xen.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] Allow get_maintainer.pl / add_maintainers.pl scripts to be called outside of xen.git
Date: Fri, 16 Aug 2019 14:28:24 +0100
Message-ID: <2b87bf90-2e11-298f-201d-a185bd92e74a@arm.com> (raw)
In-Reply-To: <E16EC776-8DAC-439A-9FF9-E5DF1F18206B@citrix.com>



On 16/08/2019 13:17, Lars Kurth wrote:
> On 16/08/2019, 11:01, "Julien Grall" <julien.grall@arm.com> wrote:
>       From my understanding, any use on mini-os.git & co will be legitimate. However,
>      we still print the WARNING in those cases.
>      
>      Usually WARNING means something needs attention. As most of the users will
>      likely copy/paste from the wiki, we are going to have report asking why the
>      WARNING is there.
>      
>      I think it would make sense to try to downgrade the message a bit when possible.
>      For instance, we could check if the section "THE REST" is present in the file
>      MAINTAINERS. If not, this is likely not a file we are able to support.
>      
> I thought about this and it is not as easy as it seems, because the script only parses
> M: ... &c lines

The script is able to parse the section name. See get_maintainer_role().

Although, I am not sure how early the function can get called.

But...

> 
> Maybe the best way to address this would be to include some identifier into the
> MAINTAINERS file (after the header with all the definitions).
> 
> FORMAT: xen-project-maintainers <version>
> (note that this is not currently picked up by the tool)
> 
> Or
> 
> V: xen-project-maintainers <version>
> (note that this would be picked up by the tool)

Any of these solutions are also a potential alternative.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 17:22 Lars Kurth
2019-08-16 10:00 ` Julien Grall
2019-08-16 12:17   ` Lars Kurth
2019-08-16 13:28     ` Julien Grall [this message]
2019-08-16 13:43       ` Lars Kurth
2019-08-23 16:34         ` Lars Kurth
2019-08-24  1:16           ` Stefano Stabellini
2019-08-27 17:13             ` Ian Jackson

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b87bf90-2e11-298f-201d-a185bd92e74a@arm.com \
    --to=julien.grall@arm.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=lars.kurth@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@archiver.kernel.org
	public-inbox-index xen-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox