xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: Lars Kurth <lars.kurth@citrix.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Julien Grall <julien.grall@arm.com>
Cc: Felipe Huici <felipe.huici@neclab.eu>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"Tim \(Xen.org\)" <tim@xen.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Florian Schmidt <florian.schmidt@neclab.eu>,
	Jan Beulich <jbeulich@suse.com>,
	Ian Jackson <Ian.Jackson@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Simon Kuenzer <simon.kuenzer@neclab.eu>
Subject: Re: [Xen-devel] [PATCH] get_maintainers.pl: Enable running the script on unikraft repos
Date: Fri, 16 Aug 2019 12:09:07 +0000	[thread overview]
Message-ID: <3044b1da5b3442aea10d46f5d232cf0d@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <BE4FC00F-77B6-492C-8BBA-C3105FAA44F4@citrix.com>

> -----Original Message-----
> From: Lars Kurth <lars.kurth@citrix.com>
> Sent: 16 August 2019 13:05
> To: Anthony Perard <anthony.perard@citrix.com>; Julien Grall <julien.grall@arm.com>
> Cc: xen-devel@lists.xenproject.org; Felipe Huici <felipe.huici@neclab.eu>; Stefano Stabellini
> <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; George
> Dunlap <George.Dunlap@citrix.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; Tim (Xen.org) <tim@xen.org>; Florian Schmidt <florian.schmidt@neclab.eu>;
> Jan Beulich <jbeulich@suse.com>; Simon Kuenzer <simon.kuenzer@neclab.eu>; Paul Durrant
> <Paul.Durrant@citrix.com>
> Subject: Re: [Xen-devel] [PATCH] get_maintainers.pl: Enable running the script on unikraft repos
> 
> Added Paul Durrant
> 
> On 16/08/2019, 12:17, "Anthony PERARD" <anthony.perard@citrix.com> wrote:
> 
>     On Fri, Aug 16, 2019 at 11:55:16AM +0100, Julien Grall wrote:
>     > Hi Lars,
>     >
>     > On 16/08/2019 11:42, Lars Kurth wrote:
>     > > Unikraft repos follow the same syntax as xen.git with the
>     > > following exceptions:
>     > > * MAINTAINERS files are called MAINTAINERS.md
>     > > * M: ... etc blocks are preceded by whitespaces for rendering as
>     > >    markup files
>     >
>     > There is an other difference. The "fallback" category is "UNIKRAFT GENERAL"
>     > and not "THE REST".
>     >
>     > >
>     > > This change will
>     > > - load MAINTAINERS.md if MAINTAINERS is not present
>     > > - deal with indented M: ... blocks
>     >
>     > One process question. Does it mean Unikraft folks will have to checkout Xen
>     > in order to use {add, get}_maintainers.pl? If so, would it make sense to
>     > have add_maintainers.pl and script_maintainers.pl in a separate repo that
>     > can be added as submodule?
> 
>     Shouldn't instead the Unikraft repo have it's one get_maintainers
>     script? xen.git's script doesn't needs to have support for every single
>     repo available on earth and Unikraft is a different project anyway.
> 
>     Usually, projects with a MAINTAINERS file have there own get_maintainers
>     script.
> 
> Well: Unikraft is part of the Xen Project.
> 
> When I started to clean up the contribution docs it became apparent that
> there is a lot of inconsistency. Ideally our contribution guide [0] would apply
> to pretty much *all* sub projects which use a mailing list based workflows
> 
> Consistency makes life for developers and also newcomers much easier. And the
> number of new devs who seem to trip over inconsistencies between projects are
> quite large (we had 3  cases in 3 weeks which I noticed).
> 
> If we start improving our CI infrastructure (which we are), it would be nice if other
> sub projects had the possibility to easily hook into it or replicate it. But that does require
> some consistency.
> 
> That's why I submitted [1] and [2]
> 
> Sub-projects with mail based workflows
> 1: Hypervisor
> 2: Hypervisor related repos (livepatch-build-tools, mini-os, xtf, ...)
> 3: Windows PV Drivers - which will require changes to their MAINTAINERS file
> 4: Unikraft
> 
> Supporting 1 - 3 should be straightforward because you would almost always
> have xen.git checked out. 4 is more different.

I'd say that folks building 3 are unlikely to have xen.git checked out.

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-08-16 12:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 10:42 [Xen-devel] [PATCH] get_maintainers.pl: Enable running the script on unikraft repos Lars Kurth
2019-08-16 10:55 ` Julien Grall
2019-08-16 11:17   ` Anthony PERARD
2019-08-16 12:05     ` Lars Kurth
2019-08-16 12:09       ` Paul Durrant [this message]
2019-08-16 12:20         ` Lars Kurth
2019-08-16 12:28           ` Paul Durrant
2019-08-16 11:41   ` Lars Kurth
2019-08-16 13:22     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3044b1da5b3442aea10d46f5d232cf0d@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=felipe.huici@neclab.eu \
    --cc=florian.schmidt@neclab.eu \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=lars.kurth@citrix.com \
    --cc=simon.kuenzer@neclab.eu \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).