From: Paul Durrant <Paul.Durrant@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Roman Shaposhnik <roman@zededa.com>,
George Dunlap <George.Dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains
Date: Mon, 12 Aug 2019 10:17:00 +0000 [thread overview]
Message-ID: <30be41c9e8bb4c239f9f67282a53a52b@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <20190802092227.43058-1-roger.pau@citrix.com>
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: 02 August 2019 10:22
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne <roger.pau@citrix.com>; Roman Shaposhnik <roman@zededa.com>; George Dunlap
> <George.Dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Kevin Tian <kevin.tian@intel.com>; Paul Durrant
> <Paul.Durrant@citrix.com>
> Subject: [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains
>
> Switch rmrr_identity_mapping to use iommu_{un}map in order to
> establish RMRR mappings for PV domains, like it's done in
> arch_iommu_hwdom_init. This solves the issue of a PV hardware domain
> not getting RMRR mappings because {set/clear}_identity_p2m_entry was
> not properly updating the iommu page tables.
>
I'm not sure this is the right approach. TBH it's not clear to me exactly what role the P2M code should play for a PV domain (I'm guessing it's probably there so that shadowing can be turned on) but it would make more sense to me if fewer paths went round the side of it and the internals handled all of the PV/HVM differences.
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-13 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 9:22 [Xen-devel] [PATCH] x86/iommu: remove usage of {set/clear}_identity_p2m_entry against PV domains Roger Pau Monne
2019-08-02 13:09 ` Jan Beulich
2019-08-12 10:17 ` Paul Durrant [this message]
2019-08-12 13:17 ` George Dunlap
2019-08-12 13:56 ` Roger Pau Monné
2019-08-12 14:24 ` George Dunlap
2019-08-12 14:55 ` Roger Pau Monné
2019-08-12 15:15 ` George Dunlap
2019-08-12 15:30 ` Roger Pau Monné
2019-12-05 11:24 ` Jan Beulich
2019-12-09 10:59 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30be41c9e8bb4c239f9f67282a53a52b@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=roman@zededa.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).