From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8DEC433ED for ; Tue, 6 Apr 2021 18:26:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 837E2613D5 for ; Tue, 6 Apr 2021 18:26:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 837E2613D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.106207.203122 (Exim 4.92) (envelope-from ) id 1lTqP2-0006Sy-75; Tue, 06 Apr 2021 18:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 106207.203122; Tue, 06 Apr 2021 18:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTqP2-0006Sr-41; Tue, 06 Apr 2021 18:26:16 +0000 Received: by outflank-mailman (input) for mailman id 106207; Tue, 06 Apr 2021 18:26:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTqP0-0006Sm-FZ for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 18:26:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTqOv-0004fw-BY; Tue, 06 Apr 2021 18:26:09 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lTqOv-0004Cj-4M; Tue, 06 Apr 2021 18:26:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=0b5sLwNEeehztREUU62IQW7PgLfii4IsKMXwP9NoywY=; b=fs/go8C4j/gVZZOHllM4d02HLB RLrLFLvFTd/yNm0aU9jdCxaQGjwF75DvuzxvI4hKmwk0FVU/9CPhGKmLnqeSAfp6Yx7Lycja484V0 gsZTzDcB1+ZdVVXtbStFTk3g/zUSNEbBt00jpFPw6H6pD7DZRwycrEDEJLTO0H5zSs3E=; Subject: Re: [PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Julien Grall , Tim Deegan , Jan Beulich , Andrew Cooper , George Dunlap , Wei Liu References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-4-julien@xen.org> From: Julien Grall Message-ID: <3108400e-8d3d-5878-b7ac-3dd9e5fe6ded@xen.org> Date: Tue, 6 Apr 2021 19:26:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Roger, On 06/04/2021 08:24, Roger Pau Monné wrote: > On Mon, Apr 05, 2021 at 04:57:02PM +0100, Julien Grall wrote: >> From: Julien Grall >> >> The function sh_audit_flags() is returning pointer to literal strings. >> They should not be modified, so the return is now const and this is >> propagated to the callers. >> >> Take the opportunity to fix the coding style in the declaration of >> sh_audit_flags. >> >> Signed-off-by: Julien Grall > > While doing the cleanup I think you could narrow the scope of the 's' > variables also, but doesn't need to be part of this patch: I think you are right. I will look at it as a follow-up. > Reviewed-by: Roger Pau Monné Thanks for the review! Cheers, -- Julien Grall