xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Christian Lindig <christian.lindig@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	David Scott <dave@recoil.org>
Subject: Re: [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()
Date: Tue, 13 Apr 2021 17:11:08 +0200	[thread overview]
Message-ID: <341cc353-b467-8335-ed0c-d5e054057e27@suse.com> (raw)
In-Reply-To: <A21C5456-8017-4A9A-9460-91D250E100FF@citrix.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1124 bytes --]

On 13.04.21 17:00, Christian Lindig wrote:
> 
> 
>> On 12 Apr 2021, at 16:22, Juergen Gross <jgross@suse.com 
>> <mailto:jgross@suse.com>> wrote:
>>
>> Instead of open coding the mapping of the p2m list use the already
>> existing xc_core_arch_map_p2m() call, especially as the current code
>> does not support guests with the linear p2m map. It should be noted
>> that this code is needed for colo/remus only.
>> [..]
>> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c 
>> b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> index d05d7bb30e..6e4bc567f5 100644
>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> @@ -32,6 +32,7 @@
>>
>> #define XC_WANT_COMPAT_MAP_FOREIGN_API
>> #include <xenctrl.h>
>> +#include <xenguest.h>
>> #include <xen-tools/libs.h>
>>
>> #include "mmap_stubs.h"
>> —
>> 2.26.2
> 
> Do we need this when there are no other changes in the file?

Yes. Some definitions moved from xenctrl.h into xenguest.h.

> 
> Acked-by: Christian Lindig <christian.lindig@citrix.com 
> <mailto:christian.lindig@citrix.com>>

Thanks,

Juergen


[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

  reply	other threads:[~2021-04-13 15:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 15:22 [PATCH v2 0/6] tools/libs: add missing support of linear p2m_list, cleanup Juergen Gross
2021-04-12 15:22 ` [PATCH v2 1/6] tools/libs/guest: fix max_pfn setting in map_p2m() Juergen Gross
2021-04-21 10:13   ` Wei Liu
2021-04-12 15:22 ` [PATCH v2 2/6] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table Juergen Gross
2021-04-21 10:13   ` Wei Liu
2021-04-21 10:17     ` Juergen Gross
2021-05-17 12:44       ` Wei Liu
2021-04-12 15:22 ` [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any() Juergen Gross
2021-04-13 15:00   ` Christian Lindig
2021-04-13 15:11     ` Juergen Gross [this message]
2021-04-21 10:14   ` Wei Liu
2021-04-12 15:22 ` [PATCH v2 4/6] tools/libs: move xc_resume.c to libxenguest Juergen Gross
2021-04-21 10:14   ` Wei Liu
2021-04-12 15:22 ` [PATCH v2 5/6] tools/libs: move xc_core* from libxenctrl " Juergen Gross
2021-04-21 10:16   ` Wei Liu
2021-04-12 15:22 ` [PATCH v2 6/6] tools/libs/guest: make some definitions private " Juergen Gross
2021-04-21 10:16   ` Wei Liu
2021-05-12  6:58 ` [PATCH v2 0/6] tools/libs: add missing support of linear p2m_list, cleanup Juergen Gross
2021-05-25  7:32   ` Juergen Gross
2021-06-02 15:10     ` Juergen Gross
2021-06-04  6:02 Juergen Gross
2021-06-04  6:02 ` [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any() Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=341cc353-b467-8335-ed0c-d5e054057e27@suse.com \
    --to=jgross@suse.com \
    --cc=christian.lindig@citrix.com \
    --cc=dave@recoil.org \
    --cc=iwj@xenproject.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).