From: Jan Beulich <firstname.lastname@example.org> To: "Roger Pau Monné" <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com>, Andrew Cooper <firstname.lastname@example.org>, Wei Liu <email@example.com> Subject: Re: [PATCH v2 1/3] x86/EFI: sections may not live at VA 0 in PE binaries Date: Fri, 23 Apr 2021 16:46:24 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <YILY6sTSMTqt27S9@Air-de-Roger> On 23.04.2021 16:25, Roger Pau Monné wrote: > On Fri, Apr 23, 2021 at 01:03:34PM +0200, Jan Beulich wrote: >> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at >> least 2.36 would silently truncate the (negative) difference when a >> section is placed below the image base. Such sections would also be >> wrongly placed ahead of all "normal" ones. Since, for the time being, >> we build xen.efi with --strip-debug anyway, .stab* can't appear. And >> .comment has an entry in /DISCARD/ already anyway in the EFI case. >> >> Because of their unclear origin, keep the directives for the ELF case >> though. >> >> Signed-off-by: Jan Beulich <email@example.com> > > Acked-by: Roger Pau Monné <firstname.lastname@example.org> Thanks. > Albeit I would remove those - even if gcc can still generate stabs > debug info I don't think it's used at all, and in any case a user > would have to also modify the build system in order to force gcc to > produce stabs debug info. I'd be fine dropping them, but I'd prefer doing so in a separate change then. As to modifying the build system - with all the different Dwarf versions and with different debug info levels I was wondering whether we shouldn't allow selecting the precise details via Kconfig. Jan
next prev parent reply other threads:[~2021-04-23 14:46 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-23 11:02 [PATCH v2 0/3] x86/EFI: build adjustments Jan Beulich 2021-04-23 11:03 ` [PATCH v2 1/3] x86/EFI: sections may not live at VA 0 in PE binaries Jan Beulich 2021-04-23 14:25 ` Roger Pau Monné 2021-04-23 14:46 ` Jan Beulich [this message] 2021-04-23 11:04 ` [PATCH v2 2/3] x86/EFI: keep debug info in xen.efi Jan Beulich 2021-04-23 14:27 ` Roger Pau Monné 2021-04-23 11:04 ` [PATCH v2 3/3] x86/EFI: don't have an overly large image size Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2 1/3] x86/EFI: sections may not live at VA 0 in PE binaries' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).