From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<xen-devel@lists.xen.org>, <kasan-dev@googlegroups.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: Juergen Gross <jgross@suse.com>,
"sergey.dyasli@citrix.com >> Sergey Dyasli"
<sergey.dyasli@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <george.dunlap@citrix.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Alexander Potapenko <glider@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Xen-devel] [PATCH v2 2/4] x86/xen: add basic KASAN support for PV kernel
Date: Wed, 22 Jan 2020 11:13:54 +0000 [thread overview]
Message-ID: <3570a312-04e9-c7f8-e348-e1c2dbd040db@citrix.com> (raw)
In-Reply-To: <28aba070-fa53-5677-c2d2-97d06514dda8@oracle.com>
On 17/01/2020 14:56, Boris Ostrovsky wrote:
>
>
> On 1/17/20 7:58 AM, Sergey Dyasli wrote:
>> --- a/arch/x86/mm/kasan_init_64.c
>> +++ b/arch/x86/mm/kasan_init_64.c
>> @@ -13,6 +13,9 @@
>> #include <linux/sched/task.h>
>> #include <linux/vmalloc.h>
>> +#include <xen/xen.h>
>> +#include <xen/xen-ops.h>
>> +
>> #include <asm/e820/types.h>
>> #include <asm/pgalloc.h>
>> #include <asm/tlbflush.h>
>> @@ -332,6 +335,11 @@ void __init kasan_early_init(void)
>> for (i = 0; pgtable_l5_enabled() && i < PTRS_PER_P4D; i++)
>> kasan_early_shadow_p4d[i] = __p4d(p4d_val);
>> + if (xen_pv_domain()) {
>> + pgd_t *pv_top_pgt = xen_pv_kasan_early_init();
>> + kasan_map_early_shadow(pv_top_pgt);
>> + }
>> +
>
>
> I'd suggest replacing this with xen_kasan_early_init() and doing everything, including PV check, there. This way non-Xen code won't need to be aware of Xen-specific details such as guest types.
This would require exporting kasan_map_early_shadow() via kasan.h.
I'm fine with either approach.
>> kasan_map_early_shadow(early_top_pgt);
>> kasan_map_early_shadow(init_top_pgt);
>> }
>> @@ -369,6 +377,8 @@ void __init kasan_init(void)
>> __pgd(__pa(tmp_p4d_table) | _KERNPG_TABLE));
>> }
>> + xen_pv_kasan_pin_pgd(early_top_pgt);
>> +
>
> And drop "_pv" here (and below) for the same reason.
This is a reasonable suggestion.
>> load_cr3(early_top_pgt);
>> __flush_tlb_all();
>> @@ -433,6 +443,8 @@ void __init kasan_init(void)
>> load_cr3(init_top_pgt);
>> __flush_tlb_all();
>> + xen_pv_kasan_unpin_pgd(early_top_pgt);
>> +
>>
--
Thanks,
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-22 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 12:58 [Xen-devel] [PATCH v2 0/4] basic KASAN support for Xen PV domains Sergey Dyasli
2020-01-17 12:58 ` [Xen-devel] [PATCH v2 1/4] kasan: introduce set_pmd_early_shadow() Sergey Dyasli
2020-01-17 12:58 ` [Xen-devel] [PATCH v2 2/4] x86/xen: add basic KASAN support for PV kernel Sergey Dyasli
2020-01-17 14:56 ` Boris Ostrovsky
2020-01-22 11:13 ` Sergey Dyasli [this message]
2020-01-21 14:54 ` kbuild test robot
2020-01-21 16:25 ` kbuild test robot
2020-01-17 12:58 ` [Xen-devel] [PATCH v2 3/4] xen: teach KASAN about grant tables Sergey Dyasli
2020-01-17 12:58 ` [Xen-devel] [PATCH v2 4/4] xen/netback: fix grant copy across page boundary Sergey Dyasli
2020-01-20 8:58 ` Paul Durrant
2020-01-22 10:07 ` Sergey Dyasli
2020-01-22 14:05 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3570a312-04e9-c7f8-e348-e1c2dbd040db@citrix.com \
--to=sergey.dyasli@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dvyukov@google.com \
--cc=george.dunlap@citrix.com \
--cc=glider@google.com \
--cc=jgross@suse.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).