From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34299C433E0 for ; Thu, 28 Jan 2021 15:08:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8C2664DE8 for ; Thu, 28 Jan 2021 15:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8C2664DE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.77165.139597 (Exim 4.92) (envelope-from ) id 1l58uP-0002fT-Sp; Thu, 28 Jan 2021 15:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 77165.139597; Thu, 28 Jan 2021 15:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l58uP-0002fM-Nr; Thu, 28 Jan 2021 15:08:33 +0000 Received: by outflank-mailman (input) for mailman id 77165; Thu, 28 Jan 2021 15:08:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l58uO-0002fH-GV for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 15:08:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l58uJ-0008BE-FH; Thu, 28 Jan 2021 15:08:27 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l58uI-0002ER-IA; Thu, 28 Jan 2021 15:08:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=94mV8buX+QgiZf1VETofOj5AlzPwFsmFXIVFgntCygo=; b=xhquJ/kwQlmEps8FhCBNkXwLst DFD2LdvScn5CRuJjQsvO4eoX3ZQjM+YdudVJl9gggFuKoqY8cZnCGYBmb9BvyW62Er/5PpSYzusvR RNdvkvJq55QRHoZUaTXNRia4E5DXN8Rp8F+iro9Lu3GHrXeVVWZvEfW9U/Sx/XnWc6TU=; Subject: Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features To: Oleksandr Cc: xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Oleksandr Tyshchenko References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-15-git-send-email-olekstysh@gmail.com> <67136393-8454-9d28-628a-bfb380fd8fc9@xen.org> <078a6aa6-2f72-d816-9e14-8132648d3370@gmail.com> <4385cb3d-c91f-08d2-e9c3-6d3d7af155b0@xen.org> From: Julien Grall Message-ID: <36f81705-764e-54e8-c314-d6f46d372a17@xen.org> Date: Thu, 28 Jan 2021 15:08:24 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 28/01/2021 14:52, Oleksandr wrote: > > On 28.01.21 16:41, Julien Grall wrote: >> On 28/01/2021 14:29, Oleksandr wrote: >>> On 28.01.21 15:39, Oleksandr wrote: >>>> >>>> On 28.01.21 13:33, Oleksandr wrote: >>>> >>>> Hi Julien >>>> >>>>> >>>>> On 28.01.21 11:40, Julien Grall wrote: >>>>> >>>>> Hi Julien >>>>> >>>>>> Hi Oleksandr, >>>>>> >>>>>> On 27/01/2021 19:20, Oleksandr wrote: >>>>>>  >  >>> So I think we may be able to drop the include from >>>>>> asm/hvm/domain.h >>>>>>> (this would avoid to include it everywhere...). >>>>>>> >>>>>>> I have tried that, but other CUs use definitions from >>>>>>> public/hvm/dm_op.h, for example: >>>>>>> >>>>>>> p2m-pt.c: In function 'p2m_type_to_flags': >>>>>>> p2m-pt.c:87:33: error: 'XEN_DMOP_IOREQ_MEM_ACCESS_WRITE' >>>>>>> undeclared (first use in this function) >>>>>>>           if ( p2m->ioreq.flags & XEN_DMOP_IOREQ_MEM_ACCESS_WRITE ) >>>>>>>                                   ^ >>>>>>> So, I would prefer to leave it as is, please let me know if you >>>>>>> think otherwise. >>>>>> >>>>>> AFAICT, there is only 2 places (p2m-pt.c and p2m-ept.c) that >>>>>> requires but doesn't directly include it. >>>>>> Folding the diff below in patch #4 should do the job: >>>>> >>>>> ok, will do >>>> >>>> >>>> Just to clarify, you mentioned about patch #4, but shouldn't we make >>>> these changes in patch #9 which actually tries to sort dm related >>>> stuff? >>> >>> or a least in patch #8 which moves the stuff from >>> asm-x86/hvm/domain.h to xen/ioreq.h (including the user of >>> XEN_DMOP_IO_RANGE_PCI), >> >> I looked at the header asm-x86/hvm/domain.h after applying patch #4, >> there is nothing requiring DMOP from there. >> >> I tried to build it with this series applied up to patch #4 + my diff. >> It does build without any issue. > > Hmm, interesting. I might miss something, but I got an build issue if I > split these changes with patch #4 and build the series up to this patch: I think I looked and tried with the wrong commit. :( This was moved in patch #7 (xen/ioreq: Make x86's hvm_ioreq_(page/vcpu/server) structs common). Sorry for the confusion. Cheers,