From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FCCC4CEC5 for ; Thu, 12 Sep 2019 14:07:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF6FB2053B for ; Thu, 12 Sep 2019 14:07:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF6FB2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8Pkm-0001ga-7z; Thu, 12 Sep 2019 14:07:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8Pkk-0001fy-Nw for xen-devel@lists.xenproject.org; Thu, 12 Sep 2019 14:07:18 +0000 X-Inumbo-ID: a0870484-d566-11e9-b299-bc764e2007e4 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a0870484-d566-11e9-b299-bc764e2007e4; Thu, 12 Sep 2019 14:07:17 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7BF19ADD9; Thu, 12 Sep 2019 14:07:16 +0000 (UTC) To: Chao Gao References: <1568272949-1086-1-git-send-email-chao.gao@intel.com> <1568272949-1086-10-git-send-email-chao.gao@intel.com> From: Jan Beulich Message-ID: <3877cba9-4707-5fe9-3224-74f825545e1b@suse.com> Date: Thu, 12 Sep 2019 16:07:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1568272949-1086-10-git-send-email-chao.gao@intel.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v10 09/16] microcode: split out apply_microcode() from cpu_request_microcode() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Sergey Dyasli , Ashok Raj , Wei Liu , Andrew Cooper , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTIuMDkuMjAxOSAwOToyMiwgQ2hhbyBHYW8gd3JvdGU6Cj4gQEAgLTI0OSw0OSArMjQ5LDgw IEBAIGJvb2wgbWljcm9jb2RlX3VwZGF0ZV9jYWNoZShzdHJ1Y3QgbWljcm9jb2RlX3BhdGNoICpw YXRjaCkKPiAgICAgIHJldHVybiB0cnVlOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IG1pY3JvY29k ZV91cGRhdGVfY3B1KGNvbnN0IHZvaWQgKmJ1Ziwgc2l6ZV90IHNpemUpCj4gKy8qCj4gKyAqIExv YWQgYSBtaWNyb2NvZGUgdXBkYXRlIHRvIGN1cnJlbnQgQ1BVLgo+ICsgKgo+ICsgKiBJZiBubyBw YXRjaCBpcyBwcm92aWRlZCwgdGhlIGNhY2hlZCBwYXRjaCB3aWxsIGJlIGxvYWRlZC4gTWljcm9j b2RlIHVwZGF0ZQo+ICsgKiBkdXJpbmcgQVBzIGJyaW5ndXAgYW5kIENQVSByZXN1bWluZyBmYWxs cyBpbnRvIHRoaXMgY2FzZS4KPiArICovCj4gK3N0YXRpYyBpbnQgbWljcm9jb2RlX3VwZGF0ZV9j cHUoY29uc3Qgc3RydWN0IG1pY3JvY29kZV9wYXRjaCAqcGF0Y2gpCj4gIHsKPiAtICAgIGludCBl cnI7Cj4gLSAgICB1bnNpZ25lZCBpbnQgY3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOwo+IC0gICAg c3RydWN0IGNwdV9zaWduYXR1cmUgKnNpZyA9ICZwZXJfY3B1KGNwdV9zaWcsIGNwdSk7Cj4gKyAg ICBpbnQgZXJyID0gbWljcm9jb2RlX29wcy0+Y29sbGVjdF9jcHVfaW5mbygmdGhpc19jcHUoY3B1 X3NpZykpOwo+ICAKPiAtICAgIHNwaW5fbG9jaygmbWljcm9jb2RlX211dGV4KTsKPiArICAgIGlm ICggdW5saWtlbHkoZXJyKSApCj4gKyAgICAgICAgcmV0dXJuIGVycjsKPiAgCj4gLSAgICBlcnIg PSBtaWNyb2NvZGVfb3BzLT5jb2xsZWN0X2NwdV9pbmZvKHNpZyk7Cj4gLSAgICBpZiAoIGxpa2Vs eSghZXJyKSApCj4gLSAgICAgICAgZXJyID0gbWljcm9jb2RlX29wcy0+Y3B1X3JlcXVlc3RfbWlj cm9jb2RlKGJ1Ziwgc2l6ZSk7Cj4gLSAgICBzcGluX3VubG9jaygmbWljcm9jb2RlX211dGV4KTsK PiArICAgIGlmICggcGF0Y2ggKQo+ICsgICAgICAgIGVyciA9IG1pY3JvY29kZV9vcHMtPmFwcGx5 X21pY3JvY29kZShwYXRjaCk7Cj4gKyAgICBlbHNlIGlmICggbWljcm9jb2RlX2NhY2hlICkKPiAr ICAgIHsKPiArICAgICAgICBzcGluX2xvY2soJm1pY3JvY29kZV9tdXRleCk7Cj4gKyAgICAgICAg ZXJyID0gbWljcm9jb2RlX29wcy0+YXBwbHlfbWljcm9jb2RlKG1pY3JvY29kZV9jYWNoZSk7Cj4g KyAgICAgICAgaWYgKCBlcnIgPT0gLUVJTyApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBt aWNyb2NvZGVfZnJlZV9wYXRjaChtaWNyb2NvZGVfY2FjaGUpOwo+ICsgICAgICAgICAgICBtaWNy b2NvZGVfY2FjaGUgPSBOVUxMOwo+ICsgICAgICAgIH0KPiArICAgICAgICBzcGluX3VubG9jaygm bWljcm9jb2RlX211dGV4KTsKPiArICAgIH0KCkknbSBoYXZpbmcgdHJvdWJsZSB1bmRlcnN0YW5k aW5nIHRoZSBsb2NraW5nIGRpc2NpcGxpbmUgaGVyZTogV2h5CmRvIHlvdSBjYWxsIC0+YXBwbHlf bWljcm9jb2RlKCkgb25jZSB3aXRoIHRoZSBsb2NrIGhlbGQgYW5kIG9uY2UKd2l0aG91dD8gSWYg dGhpcyBpcyB0byBndWFyZCBhZ2FpbnN0IG1pY3JvY29kZV9jYWNoZSBjaGFuZ2luZywKdGhlbiAo YSkgdGhlIGNoZWNrIG9mIGl0IGJlaW5nIG5vbi1OVUxMIHdvdWxkIG5lZWQgdG8gYmUgZG9uZSB3 aXRoCnRoZSBsb2NrIGhlbGQgYXMgd2VsbCBhbmQgKGIpIHlvdSdkIG5lZWQgdG8gZXhwbGFpbiB3 aHkgdGhlIG5vbi0KbG9ja2VkIGNhbGwgdG8gLT5hcHBseV9taWNyb2NvZGUoKSBpcyBva2F5LgoK SXQgY2VydGFpbmx5IHdhc24ndCB0aGlzIHdheSBpbiB2OCwgeWV0IHRoZSB2OSByZXZpc2lvbiBs b2cgYWxzbwpkb2Vzbid0IG1lbnRpb24gc3VjaCBhIChub3QgaW5zaWduaWZpY2FudCkgY2hhbmdl ICh3aGljaCBpcyBwYXJ0Cm9mIHRoZSByZWFzb24gd2h5IEkgZGlkbid0IHNwb3QgaXQgaW4gdjkp LgoKPiArICAgIGVsc2UKPiArICAgICAgICAvKiBObyBwYXRjaCB0byB1cGRhdGUgKi8KPiArICAg ICAgICBlcnIgPSAtRU5PRU5UOwo+ICAKPiAgICAgIHJldHVybiBlcnI7Cj4gIH0KPiAgCj4gLXN0 YXRpYyBsb25nIGRvX21pY3JvY29kZV91cGRhdGUodm9pZCAqX2luZm8pCj4gK3N0YXRpYyBsb25n IGRvX21pY3JvY29kZV91cGRhdGUodm9pZCAqcGF0Y2gpCj4gIHsKPiAtICAgIHN0cnVjdCBtaWNy b2NvZGVfaW5mbyAqaW5mbyA9IF9pbmZvOwo+IC0gICAgaW50IGVycm9yOwo+IC0KPiAtICAgIEJV R19PTihpbmZvLT5jcHUgIT0gc21wX3Byb2Nlc3Nvcl9pZCgpKTsKPiArICAgIHVuc2lnbmVkIGlu dCBjcHU7Cj4gKyAgICBpbnQgcmV0ID0gbWljcm9jb2RlX3VwZGF0ZV9jcHUocGF0Y2gpOwo+ICAK PiAtICAgIGVycm9yID0gbWljcm9jb2RlX3VwZGF0ZV9jcHUoaW5mby0+YnVmZmVyLCBpbmZvLT5i dWZmZXJfc2l6ZSk7Cj4gLSAgICBpZiAoIGVycm9yICkKPiAtICAgICAgICBpbmZvLT5lcnJvciA9 IGVycm9yOwo+ICsgICAgLyogU3RvcmUgdGhlIHBhdGNoIGFmdGVyIGEgc3VjY2Vzc2Z1bCBsb2Fk aW5nICovCj4gKyAgICBpZiAoICFyZXQgJiYgcGF0Y2ggKQo+ICsgICAgewo+ICsgICAgICAgIHNw aW5fbG9jaygmbWljcm9jb2RlX211dGV4KTsKPiArICAgICAgICBtaWNyb2NvZGVfdXBkYXRlX2Nh Y2hlKHBhdGNoKTsKPiArICAgICAgICBzcGluX3VubG9jaygmbWljcm9jb2RlX211dGV4KTsKPiAr ICAgICAgICBwYXRjaCA9IE5VTEw7Cj4gKyAgICB9Cj4gIAo+ICAgICAgaWYgKCBtaWNyb2NvZGVf b3BzLT5lbmRfdXBkYXRlX3BlcmNwdSApCj4gICAgICAgICAgbWljcm9jb2RlX29wcy0+ZW5kX3Vw ZGF0ZV9wZXJjcHUoKTsKPiAgCj4gLSAgICBpbmZvLT5jcHUgPSBjcHVtYXNrX25leHQoaW5mby0+ Y3B1LCAmY3B1X29ubGluZV9tYXApOwo+IC0gICAgaWYgKCBpbmZvLT5jcHUgPCBucl9jcHVfaWRz ICkKPiAtICAgICAgICByZXR1cm4gY29udGludWVfaHlwZXJjYWxsX29uX2NwdShpbmZvLT5jcHUs IGRvX21pY3JvY29kZV91cGRhdGUsIGluZm8pOwo+ICsgICAgLyoKPiArICAgICAqIEVhY2ggdGhy ZWFkIHRyaWVzIHRvIGxvYWQgdWNvZGUgYW5kIG9ubHkgdGhlIGZpcnN0IHRocmVhZCBvZiBhIGNv cmUKPiArICAgICAqIHdvdWxkIHN1Y2NlZWQuIElnbm9yZSBlcnJvciBvdGhlciB0aGFuIC1FSU8u Cj4gKyAgICAgKi8KPiArICAgIGlmICggcmV0ICE9IC1FSU8gKQo+ICsgICAgICAgIHJldCA9IDA7 CgpJIGRvbid0IHRoaW5rIHRoaXMgaXMgYSBnb29kIGlkZWEuIElnbm9yaW5nIGEgX3NwZWNpZmlj XyBlcnJvcgpjb2RlIChlLmcuIGluZGljYXRpbmcgImFscmVhZHkgbG9hZGVkIiBvciAibmV3ZXIg cGF0Y2ggYWxyZWFkeQpsb2FkZWQiKSBpcyBmaW5lLCBidXQgaGVyZSB5b3UgYWxzbyBpZ25vcmUg dGhpbmdzIGxpa2UgLUVOT01FTQpvciAtRUlOVkFMLgoKPiArICAgIGNwdSA9IGNwdW1hc2tfbmV4 dChzbXBfcHJvY2Vzc29yX2lkKCksICZjcHVfb25saW5lX21hcCk7Cj4gKyAgICBpZiAoIGNwdSA8 IG5yX2NwdV9pZHMgKQo+ICsgICAgICAgIHJldHVybiBjb250aW51ZV9oeXBlcmNhbGxfb25fY3B1 KGNwdSwgZG9fbWljcm9jb2RlX3VwZGF0ZSwgcGF0Y2gpID8KPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6 IHJldDsKCldoZW4gdGhlcmUncyBubyBtaWRkbGUgb3BlcmFuZCBJIGRvbid0IHRoaW5rID8gYW5k IDogc2hvdWxkIGJlIG9uCnNlcGFyYXRlIGxpbmVzLgoKPiBAQCAtMjk5LDMyICszMzAsNDYgQEAg aW50IG1pY3JvY29kZV91cGRhdGUoWEVOX0dVRVNUX0hBTkRMRV9QQVJBTShjb25zdF92b2lkKSBi dWYsIHVuc2lnbmVkIGxvbmcgbGVuKQo+ICAgICAgaWYgKCBtaWNyb2NvZGVfb3BzID09IE5VTEwg KQo+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAKPiAtICAgIGluZm8gPSB4bWFsbG9jX2J5 dGVzKHNpemVvZigqaW5mbykgKyBsZW4pOwo+IC0gICAgaWYgKCBpbmZvID09IE5VTEwgKQo+ICsg ICAgYnVmZmVyID0geG1hbGxvY19ieXRlcyhsZW4pOwo+ICsgICAgaWYgKCAhYnVmZmVyICkKPiAg ICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAgCj4gLSAgICByZXQgPSBjb3B5X2Zyb21fZ3Vlc3Qo aW5mby0+YnVmZmVyLCBidWYsIGxlbik7Cj4gLSAgICBpZiAoIHJldCAhPSAwICkKPiArICAgIGlm ICggY29weV9mcm9tX2d1ZXN0KGJ1ZmZlciwgYnVmLCBsZW4pICkKPiArICAgIHsKPiArICAgICAg ICByZXQgPSAtRUZBVUxUOwo+ICsgICAgICAgIGdvdG8gZnJlZTsKPiArICAgIH0KPiArCj4gKyAg ICBwYXRjaCA9IHBhcnNlX2Jsb2IoYnVmZmVyLCBsZW4pOwoKWW91IGRvbid0IGxvb2sgdG8gYmUg dXNpbmcgYnVmZmVyIGFueW1vcmUgYmVsb3cgdGhpcyBwb2ludC4gV2h5IGRvbid0CnlvdSBmcmVl IGl0IHJpZ2h0IGhlcmUsIGF2b2lkaW5nIHRoZSBuZWVkIGZvciB0aGUgImZyZWUiIGxhYmVsIGJl bG93CmFuZCBhbHNvIGZ1cnRoZXIgcmVkdWNpbmcgdGhlIG92ZXJhbGwgY29kZSBjaHVybiBhcyBp dCBzZWVtcy4KCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5v cmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZl bA==