From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D19FC43467 for ; Tue, 20 Oct 2020 10:05:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9551E22282 for ; Tue, 20 Oct 2020 10:05:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="frDqcAy6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9551E22282 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.9069.24368 (Exim 4.92) (envelope-from ) id 1kUoW6-0003jb-T6; Tue, 20 Oct 2020 10:05:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 9069.24368; Tue, 20 Oct 2020 10:05:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUoW6-0003jU-PY; Tue, 20 Oct 2020 10:05:18 +0000 Received: by outflank-mailman (input) for mailman id 9069; Tue, 20 Oct 2020 10:05:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUoW5-0003jP-Bk for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 10:05:17 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a87d765d-7032-401f-a927-c37fd2723422; Tue, 20 Oct 2020 10:05:15 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9317FAFFA; Tue, 20 Oct 2020 10:05:14 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUoW5-0003jP-Bk for xen-devel@lists.xenproject.org; Tue, 20 Oct 2020 10:05:17 +0000 X-Inumbo-ID: a87d765d-7032-401f-a927-c37fd2723422 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a87d765d-7032-401f-a927-c37fd2723422; Tue, 20 Oct 2020 10:05:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603188314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ADiIGIaN1wqYaEgkx2lrsJJhZVaGpCJeg86fFJjvVLQ=; b=frDqcAy65cBpAYBZSGKwYXCaArUG6Y0cCl5WqJU0edktJhEJHV4uR7DCJesaWl6jDrPi6X zEVKV22fRo2gwV1MVcxLMvy2pDGK9AM28bXXkY/a8+ghUDJ8UTrijeE+hwx1oiE3Rxhmor 2+R+obpcpf6PqyTlQf2CTf4rp+hVKIo= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9317FAFFA; Tue, 20 Oct 2020 10:05:14 +0000 (UTC) Subject: Re: [PATCH V2 04/23] xen/ioreq: Provide alias for the handle_mmio() To: paul@xen.org Cc: 'Oleksandr Tyshchenko' , xen-devel@lists.xenproject.org, 'Oleksandr Tyshchenko' , 'Andrew Cooper' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= , 'Wei Liu' , 'Julien Grall' , 'Stefano Stabellini' , 'Julien Grall' References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-5-git-send-email-olekstysh@gmail.com> <004701d6a6c1$6c09f860$441de920$@xen.org> From: Jan Beulich Message-ID: <38ba45dd-f1cd-a289-3ea3-75148782e126@suse.com> Date: Tue, 20 Oct 2020 12:05:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <004701d6a6c1$6c09f860$441de920$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 20.10.2020 11:14, Paul Durrant wrote: >> From: Xen-devel On Behalf Of Oleksandr Tyshchenko >> Sent: 15 October 2020 17:44 >> >> --- a/xen/include/asm-x86/hvm/ioreq.h >> +++ b/xen/include/asm-x86/hvm/ioreq.h >> @@ -181,6 +181,8 @@ static inline bool arch_hvm_ioreq_destroy(struct domain *d) >> #define IOREQ_STATUS_UNHANDLED X86EMUL_UNHANDLEABLE >> #define IOREQ_STATUS_RETRY X86EMUL_RETRY >> >> +#define ioreq_complete_mmio handle_mmio >> + > > A #define? Really? Can we not have a static inline? I guess this would require further shuffling: handle_mmio() is an inline function in hvm/emulate.h, and hvm/ioreq.h has no need to include the former (and imo it also shouldn't have). Jan