From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Durrant, Paul" <pdurrant@amazon.co.uk>,
Ian Jackson <ian.jackson@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [Xen-devel] [PATCH v4 7/7] xl: allow domid to be preserved on save/restore or migrate
Date: Thu, 30 Jan 2020 18:20:08 +0000 [thread overview]
Message-ID: <38d14767-eca0-6343-799c-49167271c9e7@citrix.com> (raw)
In-Reply-To: <07859eefc91d43859bb12e59eb6298cf@EX13D32EUC003.ant.amazon.com>
On 30/01/2020 17:42, Durrant, Paul wrote:
>> -----Original Message-----
>> From: Ian Jackson <ian.jackson@citrix.com>
>> Sent: 30 January 2020 17:29
>> To: Durrant, Paul <pdurrant@amazon.co.uk>
>> Cc: xen-devel@lists.xenproject.org; Wei Liu <wl@xen.org>; Anthony Perard
>> <anthony.perard@citrix.com>
>> Subject: Re: [PATCH v4 7/7] xl: allow domid to be preserved on
>> save/restore or migrate
>>
>> Paul Durrant writes ("[PATCH v4 7/7] xl: allow domid to be preserved on
>> save/restore or migrate"):
>>> This patch adds a '-D' command line option to save and migrate to allow
>>> the domain id to be incorporated into the saved domain configuration and
>>> hence be preserved.
>> Thanks.
>>
>> In response to v3 6/6 I wrote:
>>
>> I wonder if this should be done more in libxl. Should this be a
>> domain property ? Wei, Anthony ?
>>
>> This question remains unanswered. I'm sorry that neither Wei nor
>> Anthony had a chance to answer yet...
>>
>> Paul, do you have a reason for doing it this way ? My inclination is
>> that think doing it at the libxl layer would make more sense. Do you
>> think that would be possible ?
>>
> I'm not sure how it would work at the libxl level as the domid is part of create_info and that it transferred by xl on migration. IIUC we'd need a new libxl save record to transfer it at that level, and then I'm not sure whether we'd hit an ordering problem as we'd have to dig that save record out before we could actually create the domain.
There is definitely an ordering problem.
I agree that it should logically be part of the libxl level of the
stream, but none of that is even parsed until after the domain has been
created on the destination side.
I have no idea how easy/difficult it would be to rearrange libxl to
start parsing the migration stream before creating the domain. I think
there will be a lot of code relying on the domid already being valid.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-30 18:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:44 [Xen-devel] [PATCH v4 0/7] xl/libxl: domid allocation/preservation changes Paul Durrant
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 1/7] libxl: add definition of INVALID_DOMID to the API Paul Durrant
2020-01-22 14:52 ` Roger Pau Monné
2020-01-31 10:31 ` Durrant, Paul
2020-01-31 11:06 ` Roger Pau Monné
2020-01-31 11:10 ` Durrant, Paul
2020-01-31 12:07 ` Andrew Cooper
2020-01-31 12:11 ` Durrant, Paul
2020-01-30 17:31 ` Ian Jackson
2020-01-30 17:35 ` Durrant, Paul
2020-01-30 17:51 ` Ian Jackson
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 2/7] libxl_create: make 'soft reset' explicit Paul Durrant
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 3/7] libxl: generalise libxl__domain_userdata_lock() Paul Durrant
2020-01-30 17:04 ` Ian Jackson
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 4/7] libxl: add infrastructure to track and query 'recent' domids Paul Durrant
2020-01-30 17:23 ` Ian Jackson
2020-01-31 10:55 ` Anthony PERARD
2020-01-31 10:57 ` Durrant, Paul
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 5/7] libxl: allow creation of domains with a specified or random domid Paul Durrant
2020-01-30 17:25 ` Ian Jackson
2020-01-30 17:32 ` Durrant, Paul
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 6/7] xl.conf: introduce 'domid_policy' Paul Durrant
2020-01-22 14:44 ` [Xen-devel] [PATCH v4 7/7] xl: allow domid to be preserved on save/restore or migrate Paul Durrant
2020-01-30 17:28 ` Ian Jackson
2020-01-30 17:42 ` Durrant, Paul
2020-01-30 18:20 ` Andrew Cooper [this message]
2020-01-31 16:07 ` Wei Liu
2020-02-01 11:56 ` Durrant, Paul
2020-02-21 11:58 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d14767-eca0-6343-799c-49167271c9e7@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=pdurrant@amazon.co.uk \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).