From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F96C3A589 for ; Thu, 15 Aug 2019 14:59:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 095A820656 for ; Thu, 15 Aug 2019 14:59:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ghyfHpYw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 095A820656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyHDC-0007Qq-Jc; Thu, 15 Aug 2019 14:58:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyHDB-0007Qf-DP for xen-devel@lists.xen.org; Thu, 15 Aug 2019 14:58:45 +0000 X-Inumbo-ID: 2c7e932c-bf6d-11e9-a661-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c7e932c-bf6d-11e9-a661-bc764e2007e4; Thu, 15 Aug 2019 14:58:43 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id g67so1507350wme.1 for ; Thu, 15 Aug 2019 07:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:in-reply-to:date:cc:message-id:references :to; bh=bj60lLfC9dmHs/fXB6Wh7xYw8KZRgncwn1hYYUquIZw=; b=ghyfHpYwJqTklV2TCGFXS4iNbubRXp3oEz4lPTGbX9NYZd4WXQkNO1i6/cAfKDbThu ZnF9lMUBaFoo8Q6XSlsZendy9AJ5c4zuutRN7y1dQfLfIW/xAKF///sXymAVoh535mx/ J6awhRNuLiTnX8Yi4RrmWXcRNh+YAlyrcdGe6wgCi4mG607oZwKW7jxl1cSAhHKQyO1w e7mRVRlihYu5fsQqgfxQzITPdqf1Tgr0BomxuCNuKIO5Gv2BQsAjyzS8+U0BTAcm3SN8 m/jvF/JKA9CTWu8jUcGaZ8Dpm3hi4fT7tI5OWhVqq0uwo0G7Nj1mPoNkfFc0hoaPrGXz kV0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:in-reply-to:date:cc :message-id:references:to; bh=bj60lLfC9dmHs/fXB6Wh7xYw8KZRgncwn1hYYUquIZw=; b=sIGcwihp6TtkFRhWS1jvBPeoZLFarKUjRUqxFFSFsLuKdWjcyrIA5x8ZRLo3pD2tHD AfJguTnM7Zl2WtD5AXgZYTCUCiZXjQLGVq87xDod+SRQM1QACCeX1vT+x7wfjAQkxXkk StVvGCVMW84HQ/USaA79KoPtNILvBBXS29bPRUMLQ0qprq9bCovM2Tfiy0WZp/kjNdAh 3PI7CoOEzmaYgGVcha1qHHvFxBwcH+UJ3p8KHX5lHKVnhfRQglAd3nC7+WTs1VjZSOLa XmcSfzanm8CYK3hur7UnmyKai90MLVYXTGiJoWJc/E+/VLYNwnF/7u/gT8tLqRI1w8fL i4vw== X-Gm-Message-State: APjAAAW6u3tTqvDzbmkdtNBA8nR6uLyJqr0MMLp7erixcosz/i7YGmIV fZFZI1S0QoBlLlIGG0knC9M= X-Google-Smtp-Source: APXvYqyQkvDu+CSrx/VGzf8YRE3ih55Jg2+0IxOeI6dSEptM0/ZM+SR4K4V7SLd+0/mujNbqVcNoig== X-Received: by 2002:a7b:c21a:: with SMTP id x26mr2905076wmi.61.1565881122100; Thu, 15 Aug 2019 07:58:42 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ac18:da00:2846:9773:abb7:590b? ([2a02:c7f:ac18:da00:2846:9773:abb7:590b]) by smtp.gmail.com with ESMTPSA id u129sm2298049wmb.12.2019.08.15.07.58.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Aug 2019 07:58:41 -0700 (PDT) From: Lars Kurth X-Google-Original-From: Lars Kurth Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) In-Reply-To: <8d5350af-2ca8-a651-c43c-07372779322d@arm.com> Date: Thu, 15 Aug 2019 15:58:40 +0100 Message-Id: <3E431F27-7D89-4CE8-8FBA-86A38EBA580F@xenproject.org> References: <20190815112708.11474-1-wipawel@amazon.de> <8d5350af-2ca8-a651-c43c-07372779322d@arm.com> To: Julien Grall , Pawel Wieczorkiewicz X-Mailer: Apple Mail (2.3445.104.11) Subject: Re: [Xen-devel] [PATCH lp-metadata 2/3] livepatch: Handle arbitrary size names with the list operation X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "Tim \(Xen.org\)" , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel , mpohlack@amazon.de, Ross Lagerwall , 'Jan Beulich' , xen-devel Content-Type: multipart/mixed; boundary="===============9127710039758415482==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============9127710039758415482== Content-Type: multipart/alternative; boundary="Apple-Mail=_C5C3E986-C106-4B44-9D65-177B085477CB" --Apple-Mail=_C5C3E986-C106-4B44-9D65-177B085477CB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 15 Aug 2019, at 12:38, Julien Grall wrote: >=20 > Hi, >=20 > I am not going to answer on the patch itself but the process. >=20 > Any series (i.e more than one patch) should contain a cover letter = with a rough summary of the goal of the series. >=20 > Furthermore, this 3 patches series has been received as 3 separate = threads (i.e in-reply-to is missing). This is making difficult to know = that all the patches belongs to the same series. In general, all patches = are send as in-reply-to the cover letter. So all the patches sticks = together in one thread. >=20 > The cover letter can be generated via git format-patch --cover-letter. = Threading is done automatically with git-send-email when all the patches = as passed in arguments. >=20 > For more details how to do it, you can read: >=20 > = https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_= Patch_Series = >=20 > Cheers, Hi Pawel,=20 thank you for submitting the patch series.=20 We had a couple of new starters recently who followed a similar pattern = to you. As a result of this, I recently updated the following docs https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches = - = Definitions and general workflow The bit which saves the most work is = https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_= Patch_Series = As for Julien's comment on the threading: see the --thread and = --cover-letter option as described in the Sending a Patch Series https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_Git = - Basic = Git commands fitting into the workflow, including how to deal with = reviews https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGit = - = Basic StGit commands fitting into the workflow, including how to deal = with reviews I have not had time to play with git series yet. If anyone in your team = uses it let me know In any case: if you follow the instructions the entire submission = process and dealing with review comments becomes much easier.=20 As a newcomer, to contributing to Xen, I would greatly appreciate if you = could let me know of any issues with the docs, such that we can fix them Regards Lars --Apple-Mail=_C5C3E986-C106-4B44-9D65-177B085477CB Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 15 Aug 2019, at 12:38, Julien Grall <julien.grall@arm.com> wrote:

Hi,

I am not = going to answer on the patch itself but the process.

Any series = (i.e more than one patch) should contain a cover letter with a rough = summary of the goal of the series.

Furthermore, this 3 patches series has been received as 3 = separate threads (i.e in-reply-to is missing). This is making difficult = to know that all the patches belongs to the same series. In general, all = patches are send as in-reply-to the cover letter. So all the patches = sticks together in one thread.

The cover letter can be generated via git format-patch = --cover-letter. Threading is done automatically with git-send-email when = all the patches as passed in arguments.

For more details how to do it, you can read:

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches= #Sending_a_Patch_Series

Cheers,

Hi Pawel, 

thank you for submitting the patch = series. 

We had a couple of new = starters recently who followed a similar pattern to you. As a result of = this, I recently updated the following docs

As for Julien's comment on the = threading: see the --thread and --cover-letter option as described = in the Sending a Patch Series

https://wiki.xenproject.org/wiki/Managing_Xen_Patches_with_StGi= t - Basic StGit commands fitting into the workflow, including = how to deal with reviews
I have not had time to play with git = series yet. If anyone in your team uses it let me know

In any case: if you follow the instructions the = entire submission process and dealing with review comments becomes much = easier. 

As a newcomer, to = contributing to Xen, I would greatly appreciate if you could let me know = of any issues with the docs, such that we can fix them

Regards
Lars



= --Apple-Mail=_C5C3E986-C106-4B44-9D65-177B085477CB-- --===============9127710039758415482== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============9127710039758415482==--