From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D19C433DB for ; Tue, 30 Mar 2021 15:21:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9B02619A7 for ; Tue, 30 Mar 2021 15:21:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9B02619A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.103568.197554 (Exim 4.92) (envelope-from ) id 1lRGAz-0003Jy-U7; Tue, 30 Mar 2021 15:21:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103568.197554; Tue, 30 Mar 2021 15:21:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAz-0003Jq-QJ; Tue, 30 Mar 2021 15:21:05 +0000 Received: by outflank-mailman (input) for mailman id 103568; Tue, 30 Mar 2021 15:21:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lRGAx-0003BT-TM for xen-devel@lists.xenproject.org; Tue, 30 Mar 2021 15:21:03 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7d8b7aba-23d3-43d0-bf25-f3e86880361e; Tue, 30 Mar 2021 15:21:02 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 45424B090; Tue, 30 Mar 2021 15:21:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d8b7aba-23d3-43d0-bf25-f3e86880361e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617117661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZK9XnRQ2r2TuoLAwRNNkf3RMjShk6frjeRoB81m4JcQ=; b=OFbhKwaWaAs4k/2Q7C0b7PvakySvXUNCrCe5GVPIZVlBwBJk5q1aLrC9907SCcPN10ISaZ GjNZsLuVJtKNhB1a6i8d86dKmXhunL2d2vOMGYsCZQ4wqfr81GJdq3R2RlW0j8jMgXwhuk SCsAQusGYrfz3wY+6067dxyvwm8sT6Y= Subject: Re: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy To: Roger Pau Monne Cc: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20210323095849.37858-1-roger.pau@citrix.com> <20210323095849.37858-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: <3a8eb714-563f-02b7-3098-6479789d7e8b@suse.com> Date: Tue, 30 Mar 2021 17:21:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210323095849.37858-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.03.2021 10:58, Roger Pau Monne wrote: > Also change libxl__cpuid_legacy to propagate the error from > xc_cpuid_apply_policy into callers. > > Signed-off-by: Roger Pau Monné This looks to do what it means to do and also none of the present callers of the functions modified here ignore the return values, so Reviewed-by: Jan Beulich I wonder however how to ensure similar problems won't get re-introduced down the road. In the hypervisor I'd recommend adding __must_check everywhere, but I have no idea what the tool stack policy is in this regard. Jan