From: Jan Beulich <jbeulich@suse.com>
To: Connor Davis <connojdavis@gmail.com>
Cc: Bobby Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair23@gmail.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 2/4] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH
Date: Tue, 25 May 2021 10:44:33 +0200 [thread overview]
Message-ID: <3b872d59-4330-68ee-c62b-230f5d6cb2cf@suse.com> (raw)
In-Reply-To: <f76852db6601b1bf243781b0b8b16c7a6fdc8a01.1621712830.git.connojdavis@gmail.com>
On 24.05.2021 16:34, Connor Davis wrote:
> The variables iommu_enabled and iommu_dont_flush_iotlb are defined in
> drivers/passthrough/iommu.c and are referenced in common code, which
> causes the link to fail when !CONFIG_HAS_PASSTHROUGH.
>
> Guard references to these variables in common code so that xen
> builds when !CONFIG_HAS_PASSTHROUGH.
>
> Signed-off-by: Connor Davis <connojdavis@gmail.com>
Somewhat hesitantly
Acked-by: Jan Beulich <jbeulich@suse.com>
with ...
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -51,9 +51,15 @@ static inline bool_t dfn_eq(dfn_t x, dfn_t y)
> return dfn_x(x) == dfn_x(y);
> }
>
> -extern bool_t iommu_enable, iommu_enabled;
> +extern bool_t iommu_enable;
... just "bool" used here, as I think I did say before. Can be taken
care of while committing, I think.
Jan
next prev parent reply other threads:[~2021-05-25 8:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 14:34 [PATCH v4 0/4] Minimal build for RISCV Connor Davis
2021-05-24 14:34 ` [PATCH v4 1/4] xen/char: Default HAS_NS16550 to y only for X86 and ARM Connor Davis
2021-05-25 7:02 ` Jan Beulich
2021-05-25 7:06 ` Jan Beulich
2021-05-28 7:45 ` Jan Beulich
2021-05-24 14:34 ` [PATCH v4 2/4] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH Connor Davis
2021-05-25 8:44 ` Jan Beulich [this message]
2021-05-28 7:41 ` Jan Beulich
2021-05-24 14:34 ` [PATCH v4 3/4] xen: Add files needed for minimal riscv build Connor Davis
2021-05-25 8:48 ` Jan Beulich
2021-05-25 18:13 ` Bob Eshleman
2021-06-01 2:26 ` Connor Davis
2021-06-01 6:03 ` Jan Beulich
2021-06-01 8:40 ` Julien Grall
2021-06-02 2:13 ` Connor Davis
2021-06-03 23:26 ` Alistair Francis
2021-06-01 6:11 ` Jan Beulich
2021-06-02 2:12 ` Connor Davis
2021-05-24 14:34 ` [PATCH v4 4/4] automation: Add container for riscv64 builds Connor Davis
2021-05-25 9:24 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b872d59-4330-68ee-c62b-230f5d6cb2cf@suse.com \
--to=jbeulich@suse.com \
--cc=alistair23@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).