xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/xenstored: Wire properly the command line option -M/--path-max
Date: Sun, 25 Apr 2021 13:56:43 +0100	[thread overview]
Message-ID: <3c1f428d-242b-d076-824d-cc382e413cb4@xen.org> (raw)
In-Reply-To: <673f6a7e-a63c-ca0c-054d-5c33682e901e@suse.com>

Hi Juergen,

On 21/04/2021 16:07, Juergen Gross wrote:
> On 21.04.21 16:02, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The command line option -M/--path-max was meant to be added by
>> commit 924bf8c793cb "tools/xenstore: rework path length check" but this
>> wasn't wired through properly.
>>
>> Fix it by adding the missing "case 'M':".
>>
>> Fixes: 924bf8c793cb ("tools/xenstore: rework path length check")
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks! I have committed it.

> I wonder why no compiler cared about the obviously dead coding.
Coverity actually spotted it (see CID-1470790) back in December 2020. 
Although, I wasn't aware of it because I just check coverity now.

Cheers,

-- 
Julien Grall


      reply	other threads:[~2021-04-25 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 14:02 Julien Grall
2021-04-21 14:10 ` Luca Fancellu
2021-04-21 15:07 ` Juergen Gross
2021-04-25 12:56   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c1f428d-242b-d076-824d-cc382e413cb4@xen.org \
    --to=julien@xen.org \
    --cc=iwj@xenproject.org \
    --cc=jgrall@amazon.com \
    --cc=jgross@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] tools/xenstored: Wire properly the command line option -M/--path-max' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).