From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19657C433E0 for ; Thu, 21 May 2020 10:26:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD67C20721 for ; Thu, 21 May 2020 10:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD67C20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbiP8-00016T-DK; Thu, 21 May 2020 10:26:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jbiP7-00016O-Ug for xen-devel@lists.xenproject.org; Thu, 21 May 2020 10:26:21 +0000 X-Inumbo-ID: 82eff54b-9b4d-11ea-aaee-12813bfff9fa Received: from ppsw-40.csi.cam.ac.uk (unknown [131.111.8.140]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 82eff54b-9b4d-11ea-aaee-12813bfff9fa; Thu, 21 May 2020 10:26:20 +0000 (UTC) X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: http://help.uis.cam.ac.uk/email-scanner-virus Received: from 88-109-182-220.dynamic.dsl.as9105.com ([88.109.182.220]:40636 helo=[192.168.1.219]) by ppsw-40.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:465) with esmtpsa (PLAIN:amc96) (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) id 1jbiP2-000tJn-jr (Exim 4.92.3) (return-path ); Thu, 21 May 2020 11:26:16 +0100 Subject: Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p() To: paul@xen.org, 'Xen-devel' References: <20200521090428.11425-1-andrew.cooper3@citrix.com> <003e01d62f58$66bbcea0$34336be0$@xen.org> From: Andrew Cooper Message-ID: <3c829c7d-2a3f-0d15-ea77-3a88df57aaaa@citrix.com> Date: Thu, 21 May 2020 11:26:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <003e01d62f58$66bbcea0$34336be0$@xen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: 'Tim Deegan' , 'Jan Beulich' , 'Wei Liu' , =?UTF-8?B?J1JvZ2VyIFBhdSBNb25uw6kn?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21/05/2020 11:12, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel On Behalf Of Andrew Cooper >> Sent: 21 May 2020 10:04 >> To: Xen-devel >> Cc: Andrew Cooper ; Tim Deegan ; Wei Liu ; Jan >> Beulich ; Roger Pau Monné >> Subject: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p() >> >> When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with: >> >> common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared ‘static’ but never defined [- >> Werror=unused-function] >> static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn, >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> due to an unguarded forward declaration. > Is this, perhaps, an argument for making SHADOW_OPTIMIZATIONS tunable via Kconfig so that randconfig could catch things like this? Given enough TUITS, yes. ~Andrew