From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC8BC433E3 for ; Fri, 24 Jul 2020 16:54:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B4892067D for ; Fri, 24 Jul 2020 16:54:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="VyM+LrCf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B4892067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jz0xn-0002du-JW; Fri, 24 Jul 2020 16:54:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jz0xm-0002dp-6n for xen-devel@lists.xenproject.org; Fri, 24 Jul 2020 16:54:26 +0000 X-Inumbo-ID: 54864a3e-cdce-11ea-8858-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 54864a3e-cdce-11ea-8858-bc764e2007e4; Fri, 24 Jul 2020 16:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WWtqmrMo2elkg9mLTxYQ8fXFFW+71EuNsD/v4f+ImLM=; b=VyM+LrCf6xUTgvvLwSHYGPYw3S juzI5inNvOG5poqTEMizJhrocLdGqlGHRAdmt4MvEuxWLdHHBpSb8Vh0HwyzD4s4I7cKICTkMobMU 4ytI8+RkjFT2iRry8Lb1DcmyVyecjF3f1TLHXfhlp7yIe5mC/Nj0oD3JMelQ1/4y6yQc=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jz0xj-0005ED-Ay; Fri, 24 Jul 2020 16:54:23 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jz0xj-00023s-0n; Fri, 24 Jul 2020 16:54:23 +0000 Subject: Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM. To: Jan Beulich References: <64ebd4ef614b36a5844c52426a4a6a4a23b1f087.1595511416.git.rahul.singh@arm.com> <20200724144404.GJ7191@Air-de-Roger> <0c53b2cb-47e9-f34e-8922-7095669175be@xen.org> <980fc583-edb6-b536-f211-f6b8ea6d21a7@suse.com> From: Julien Grall Message-ID: <3e15d186-e323-613f-05a2-ee02480d74cf@xen.org> Date: Fri, 24 Jul 2020 17:54:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <980fc583-edb6-b536-f211-f6b8ea6d21a7@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Rahul Singh , Bertrand.Marquis@arm.com, Stefano Stabellini , xen-devel@lists.xenproject.org, nd@arm.com, Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Jan, On 24/07/2020 17:01, Jan Beulich wrote: > On 24.07.2020 17:15, Julien Grall wrote: >> On 24/07/2020 15:44, Roger Pau Monné wrote: >>>> + >>>> + struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, sbdf.bus); >>>> + >>>> + if ( unlikely(!bridge) ) >>>> + { >>>> + printk(XENLOG_ERR "Unable to find bridge for "PRI_pci"\n", >>>> + sbdf.seg, sbdf.bus, sbdf.dev, sbdf.fn); >>> >>> I had a patch to add a custom modifier to out printf format in >>> order to handle pci_sbdf_t natively: >>> >>> https://patchew.org/Xen/20190822065132.48200-1-roger.pau@citrix.com/ >>> >>> It missed maintainers Acks and was never committed. Since you are >>> doing a bunch of work here, and likely adding a lot of SBDF related >>> prints, feel free to import the modifier (%pp) and use in your code >>> (do not attempt to switch existing users, or it's likely to get >>> stuck again). >> >> I forgot about this patch :/. It would be good to revive it. Which acks >> are you missing? > > It wasn't so much missing acks, but a controversy. And that not so much > about switching existing users, but whether to indeed derive this from > %p (which I continue to consider inefficient). Looking at the thread, I can see you (relunctantly) acked any components that you are the sole maintainers. Kevin gave his acked for the vtd code and I gave it mine for the common code. I would suggest to not rehash the argument unless another maintainer agree with your position. It loosk like to me the next step is for Roger (or someone else) to resend the patch so we could collect the missing ack (I think there is only one missing from Andrew). Cheers, -- Julien Grall