From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2670ECAAD8 for ; Tue, 20 Sep 2022 04:51:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.409117.652016 (Exim 4.92) (envelope-from ) id 1oaVDn-0001RD-Q3; Tue, 20 Sep 2022 04:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409117.652016; Tue, 20 Sep 2022 04:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVDn-0001R6-N3; Tue, 20 Sep 2022 04:50:59 +0000 Received: by outflank-mailman (input) for mailman id 409117; Tue, 20 Sep 2022 04:50:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oaVDl-0001R0-S3 for xen-devel@lists.xenproject.org; Tue, 20 Sep 2022 04:50:57 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0625675-389f-11ed-bad8-01ff208a15ba; Tue, 20 Sep 2022 06:50:57 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id n12so2282556wrx.9 for ; Mon, 19 Sep 2022 21:50:56 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c154c00b003a62052053csm20902170wmg.18.2022.09.19.21.50.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 21:50:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d0625675-389f-11ed-bad8-01ff208a15ba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=AOjdR7SFZiHY1uiELRpo0rpHv870srIhKUXZHTwkqUI=; b=MfFJU2m3Hp+LpkC7yASngF/y3vweUTL23ftLfII94KRq1fh9uTp6TvbPfhA5JM7g/4 BVreu+b5bogN3xvS5EzGpIbQ3ng9dHhuRm5e0Vic64Hq0UMgtlOEtv6O2XVqLujTsiv+ 6KwJpHbGhyeJM9cFKDzK2kyye8yL1PlPeQc88f8cJP9g1alsMDm8NjaIbYUlA7jlTSSm LQm1oSmvlVAB4NutamOypWH24lc9dzVMwaSgX/dOayiJh8AZara/qgGIpz+9dkwcj6y7 O5rpwXra/Dcl72TDHgcZpvuttTtBdPNyqw9sm6ljJOpkgbDiG4P62kLG+lMBo2jwJzze Fw0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=AOjdR7SFZiHY1uiELRpo0rpHv870srIhKUXZHTwkqUI=; b=i2J7LilaL12NzSruKT29rgYmO5Q7sIowmxW3/bsG/B1aYFZz5eskBdDqhbf64PVKuJ X9+cF79sGoQr5f1S8eY5uKrZGnwyXc6QfBWBtjHqwQL4ZHgPwgfvy6MgbvbO9qIkvvGb 3MuVvdauapwdtrSAiu5YKTOTD4J7ClsXpAskDQaGdgOAdiJKDk0/tmq/nlD3eGZSlsBe A1rE5i1prc5lbYtBDhqyqfHR/k5vGZxh6DODyVrnEmpkGbvU95CoItU1wG6VG08Vzvv6 6jdXKazzZuLbYC0j+9R5v2gC5E2898Js9v/qn3fqOcybNLduDkRnlAjqNFzDvHFDxgiH YW5A== X-Gm-Message-State: ACrzQf23CFdJUr71f3knnBhmZw4YgHIeqDMvoVu9pzaEyqQjJpyNtrEU adR2RtIzKYqhrtSXsKKxWEg= X-Google-Smtp-Source: AMsMyM5Zw3Yb5SwTXaejaf1oX7/x3SNh9tZo3tfn0QC4ZXWZZxDxIYm9wdK1FGZNM51fQBEYeXIOWA== X-Received: by 2002:a5d:550c:0:b0:22b:1942:4bf6 with SMTP id b12-20020a5d550c000000b0022b19424bf6mr190273wrv.520.1663649456084; Mon, 19 Sep 2022 21:50:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <3fcb707c-47c3-7696-86ec-62048e39bfe1@amsat.org> Date: Tue, 20 Sep 2022 06:50:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/9] exec/hwaddr.h: Add missing include Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Markus Armbruster , Eric Auger , David Gibson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Christian Borntraeger , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , qemu-block@nongnu.org, Eduardo Habkost , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , qemu-ppc@nongnu.org, Cornelia Huck , Palmer Dabbelt , Helge Deller , Stefano Stabellini , qemu-riscv@nongnu.org, Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , xen-devel@lists.xenproject.org, Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , kvm@vger.kernel.org, Qiuhao Li , John G Johnson , Bin Meng , Sunil Muthuswamy , Max Filippov , qemu-arm@nongnu.org, Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-3-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220919231720.163121-3-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/9/22 01:17, Bernhard Beschow wrote: > The next commit would not compile w/o the include directive. > > Signed-off-by: Bernhard Beschow > --- > include/exec/hwaddr.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h > index 8f16d179a8..616255317c 100644 > --- a/include/exec/hwaddr.h > +++ b/include/exec/hwaddr.h > @@ -3,6 +3,7 @@ > #ifndef HWADDR_H > #define HWADDR_H > > +#include "qemu/osdep.h" NAck: This is an anti-pattern. "qemu/osdep.h" must not be included in .h, only in .c. Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in the next patch?