From: Jan Beulich <firstname.lastname@example.org> To: Andrew Cooper <email@example.com> Cc: "Roger Pau Monné" <firstname.lastname@example.org>, "Wei Liu" <email@example.com>, "Stefano Stabellini" <firstname.lastname@example.org>, "Julien Grall" <email@example.com>, "Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>, "Juergen Gross" <firstname.lastname@example.org>, "Tim Deegan" <email@example.com>, Xen-devel <firstname.lastname@example.org> Subject: Re: [PATCH 0/7] xen: Switch to using -Og for debug builds Date: Wed, 21 Apr 2021 11:51:50 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 21.04.2021 11:31, Andrew Cooper wrote: > On 19/04/2021 16:45, Jan Beulich wrote: >> On 19.04.2021 16:01, Andrew Cooper wrote: >>> As with the toolstack side, we ought to use -Og for debug builds. >>> >>> All fixes are trivial. The first 3 are understandable, given reduced >>> optimisations. The next 3 are, AFAICT, bogus diagnostics. >>> >>> Andrew Cooper (7): >>> xen/arm: Make make_cpus_node() compile at -Og >>> x86/shim: Fix compilation at -Og >>> x86/sysctl: Make arch_do_sysctl() compile at -Og >>> x86/irq: Make create_irq() compile at -Og >>> xen/efi: Make efi_start() compile at -Og >>> x86/shadow: Make _shadow_prealloc() compile at -Og >>> xen: Use -Og for debug builds when available >> Acked-by: Jan Beulich <email@example.com> >> >> I'd like to ask though that at least for the bogus warnings you >> amend the commit messages with the gcc version these were observed >> with. Perhaps even those seemingly bogus initializers would >> benefit from a very brief comment (or else there's a fair chance >> of them getting removed again at some point). > > I'm afraid I don't have that information easily to hand, but all issues > were found by distro-provided compilers included in our Gitlab > infrastructure. Well, okay, then we'll need to live with said risk. As an aside I'd like to remind you though that on past occasions of working around compiler oddities, I was asked as well to provide compiler version information ... Jan
prev parent reply other threads:[~2021-04-21 9:52 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 14:01 Andrew Cooper 2021-04-19 14:01 ` [PATCH 1/7] xen/arm: Make make_cpus_node() compile at -Og Andrew Cooper 2021-04-22 18:20 ` Julien Grall 2021-04-19 14:01 ` [PATCH 2/7] x86/shim: Fix compilation " Andrew Cooper 2021-04-19 14:01 ` [PATCH 3/7] x86/sysctl: Make arch_do_sysctl() compile " Andrew Cooper 2021-04-19 14:01 ` [PATCH 4/7] x86/irq: Make create_irq() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 5/7] xen/efi: Make efi_start() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 6/7] x86/shadow: Make _shadow_prealloc() " Andrew Cooper 2021-04-22 7:52 ` Tim Deegan 2021-04-19 14:01 ` [PATCH 7/7] xen: Use -Og for debug builds when available Andrew Cooper 2021-04-19 15:45 ` [PATCH 0/7] xen: Switch to using -Og for debug builds Jan Beulich 2021-04-21 9:31 ` Andrew Cooper 2021-04-21 9:51 ` Jan Beulich [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Volodymyr_Babchuk@epam.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/7] xen: Switch to using -Og for debug builds' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).