From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E12BC433B4 for ; Wed, 21 Apr 2021 09:52:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5A2861440 for ; Wed, 21 Apr 2021 09:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5A2861440 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.114252.217682 (Exim 4.92) (envelope-from ) id 1lZ9WU-0003jH-KZ; Wed, 21 Apr 2021 09:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 114252.217682; Wed, 21 Apr 2021 09:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZ9WU-0003jA-Ge; Wed, 21 Apr 2021 09:51:54 +0000 Received: by outflank-mailman (input) for mailman id 114252; Wed, 21 Apr 2021 09:51:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZ9WS-0003iy-S8 for xen-devel@lists.xenproject.org; Wed, 21 Apr 2021 09:51:52 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9e216584-d0c0-4fb9-9321-41e7766bb539; Wed, 21 Apr 2021 09:51:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AD26CB2E4; Wed, 21 Apr 2021 09:51:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e216584-d0c0-4fb9-9321-41e7766bb539 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618998710; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NEvQf3uRl+Sgc1WdAVwt3AFrn2VAvyklQQFfj6at9IA=; b=LVV99KuWT7Evv0qRB2Y/Zq5YMWGbmfT7pFviSYF7o/eHFLXuXz4wsZIYd86f1fYTiKZxF8 GShd8Sx1Jwdd0ZgJk+ZS7TSMx4qEFuqdxrjntvF6ltnh1qb7TR3YDKEGJV8G4CSw4kCAI6 LkEwDgQoK5T2YkX2MPFmWLj2zrPiLgo= Subject: Re: [PATCH 0/7] xen: Switch to using -Og for debug builds To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Juergen Gross , Tim Deegan , Xen-devel References: <20210419140132.16909-1-andrew.cooper3@citrix.com> <9e8e116a-f4c3-e6bf-edee-d48e76a3d005@suse.com> From: Jan Beulich Message-ID: <3fda551c-fff3-d86e-d2cd-23408693bb7c@suse.com> Date: Wed, 21 Apr 2021 11:51:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 21.04.2021 11:31, Andrew Cooper wrote: > On 19/04/2021 16:45, Jan Beulich wrote: >> On 19.04.2021 16:01, Andrew Cooper wrote: >>> As with the toolstack side, we ought to use -Og for debug builds. >>> >>> All fixes are trivial. The first 3 are understandable, given reduced >>> optimisations. The next 3 are, AFAICT, bogus diagnostics. >>> >>> Andrew Cooper (7): >>> xen/arm: Make make_cpus_node() compile at -Og >>> x86/shim: Fix compilation at -Og >>> x86/sysctl: Make arch_do_sysctl() compile at -Og >>> x86/irq: Make create_irq() compile at -Og >>> xen/efi: Make efi_start() compile at -Og >>> x86/shadow: Make _shadow_prealloc() compile at -Og >>> xen: Use -Og for debug builds when available >> Acked-by: Jan Beulich >> >> I'd like to ask though that at least for the bogus warnings you >> amend the commit messages with the gcc version these were observed >> with. Perhaps even those seemingly bogus initializers would >> benefit from a very brief comment (or else there's a fair chance >> of them getting removed again at some point). > > I'm afraid I don't have that information easily to hand, but all issues > were found by distro-provided compilers included in our Gitlab > infrastructure. Well, okay, then we'll need to live with said risk. As an aside I'd like to remind you though that on past occasions of working around compiler oddities, I was asked as well to provide compiler version information ... Jan