From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB91C4363D for ; Fri, 25 Sep 2020 06:51:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18DAB22211 for ; Fri, 25 Sep 2020 06:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="k+feRLpe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18DAB22211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kLhZn-00011L-Nv; Fri, 25 Sep 2020 06:51:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kLhZn-00011G-9l for xen-devel@lists.xenproject.org; Fri, 25 Sep 2020 06:51:27 +0000 X-Inumbo-ID: 0931068a-e63d-4b2a-aabb-9865dbad803e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0931068a-e63d-4b2a-aabb-9865dbad803e; Fri, 25 Sep 2020 06:51:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601016685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7dEVjCZMELgtDiG1r+HTZ1owugKfyBFJmDWnF3hPnOs=; b=k+feRLpelOz4uOrZATO5qGV3KddIRzommIH6GecIa/NKk6X/lk9JZzIGv3c0Meq66egLcM mi3nw76Shj+yZ1eH/1ptB9PoyY4OYE40m3ytHgf4qT040h3/H+BshNflAoHJxFmog5NZIA eE8FvVJrlpEDv2hkMMfyWpl/zZeLpnM= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BEBC6AD52; Fri, 25 Sep 2020 06:51:25 +0000 (UTC) Subject: Re: [PATCH V1 09/16] arm/ioreq: Introduce arch specific bits for IOREQ/DM features To: Oleksandr Cc: Julien Grall , xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Stefano Stabellini , Volodymyr Babchuk , Julien Grall References: <1599769330-17656-1-git-send-email-olekstysh@gmail.com> <1599769330-17656-10-git-send-email-olekstysh@gmail.com> <7fbab25d-18a9-83d6-2596-f0f9d149058c@gmail.com> From: Jan Beulich Message-ID: <42aea418-a8f4-e2c0-fc08-b0c504da31bb@suse.com> Date: Fri, 25 Sep 2020 08:51:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 24.09.2020 20:02, Oleksandr wrote: > On 24.09.20 19:02, Oleksandr wrote: > Julien, I noticed that three fields mmio* are not used within current > series on Arm. Do we expect them to be used later on? > I would rather not add fields which are not used. We could add them when > needed. > > Would be the following acceptable? > 1. Both fields "io_completion" and "io_req" (which seems to be the only > fields used in common/ioreq.c) are moved to common struct vcpu as part > of struct vcpu_io, >     enum hvm_io_completion is also moved (and renamed). > 2. We remove everything related to hvm_vcpu* from the Arm header. > 3. x86's struct hvm_vcpu_io stays as it is (but without two fields > "io_completion" and "io_req"). >     I think, this way we separate a common part and reduce Xen changes > (which are getting bigger). If this works, it would be my preference too. So far I was left under the impression that you did move / mention further fields for a reason. Jan