From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/S3: Drop {save,restore}_rest_processor_state() completely
Date: Wed, 29 Apr 2020 13:16:43 +0200 [thread overview]
Message-ID: <42c1a2ec-51a1-7b03-aea5-f8ffe80d6928@suse.com> (raw)
In-Reply-To: <20200429110903.15418-1-andrew.cooper3@citrix.com>
On 29.04.2020 13:09, Andrew Cooper wrote:
> --- a/xen/arch/x86/boot/trampoline.S
> +++ b/xen/arch/x86/boot/trampoline.S
> @@ -91,6 +91,11 @@ trampoline_protmode_entry:
> and %edi,%edx
> wrmsr
> 1:
> + /* Set up PAT before enabling paging. */
> + mov $XEN_MSR_PAT & 0xffffffff, %eax
> + mov $XEN_MSR_PAT >> 32, %edx
> + mov $MSR_IA32_CR_PAT, %ecx
> + wrmsr
Doesn't this also eliminate the need for cpu_init() doing this?
If you agree with that one also dropped
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2020-04-29 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 11:09 [PATCH] x86/S3: Drop {save, restore}_rest_processor_state() completely Andrew Cooper
2020-04-29 11:16 ` Jan Beulich [this message]
2020-04-29 11:32 ` [PATCH] x86/S3: Drop {save,restore}_rest_processor_state() completely Andrew Cooper
2020-04-29 13:25 ` Jan Beulich
2020-04-29 13:36 ` Andrew Cooper
2020-04-29 13:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c1a2ec-51a1-7b03-aea5-f8ffe80d6928@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).