From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v3 2/6] build: convert crash_debug to Kconfig Date: Tue, 17 May 2016 21:15:57 -0500 Message-ID: <44b4d3c1-c125-d7d1-2506-1d1a43612fd9@cardoe.com> References: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> <1462914329-8797-3-git-send-email-cardoe@cardoe.com> <57331BB702000078000EA7E6@prv-mh.provo.novell.com> <8f1adc1b-0639-46ff-caec-2db9b0578f4a@cardoe.com> <5734631E02000078000EAD55@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7963374280159993018==" Return-path: In-Reply-To: <5734631E02000078000EAD55@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Tim Deegan , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7963374280159993018== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xqiq8agdpPigl4ARjJhJFaUo3bJIv1aa8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xqiq8agdpPigl4ARjJhJFaUo3bJIv1aa8 Content-Type: multipart/mixed; boundary="xW9DapSNtMgmT0AoGDWI2lm0DgDFrncaU" From: Doug Goldstein To: Jan Beulich Cc: Andrew Cooper , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , xen-devel@lists.xen.org, Konrad Rzeszutek Wilk , Tim Deegan Message-ID: <44b4d3c1-c125-d7d1-2506-1d1a43612fd9@cardoe.com> Subject: Re: [PATCH v3 2/6] build: convert crash_debug to Kconfig References: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> <1462914329-8797-3-git-send-email-cardoe@cardoe.com> <57331BB702000078000EA7E6@prv-mh.provo.novell.com> <8f1adc1b-0639-46ff-caec-2db9b0578f4a@cardoe.com> <5734631E02000078000EAD55@prv-mh.provo.novell.com> In-Reply-To: <5734631E02000078000EAD55@prv-mh.provo.novell.com> --xW9DapSNtMgmT0AoGDWI2lm0DgDFrncaU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/12/16 4:03 AM, Jan Beulich wrote: >>>> On 11.05.16 at 19:35, wrote: >> On 5/11/16 4:47 AM, Jan Beulich wrote: >>>>>> On 10.05.16 at 23:05, wrote: >>>> --- a/xen/Kconfig.debug >>>> +++ b/xen/Kconfig.debug >>>> @@ -1,6 +1,13 @@ >>>> =20 >>>> menu "Debugging Options" >>>> =20 >>>> +config CRASH_DEBUG >>>> + bool "Crash Debugging Support" >>>> + depends on X86 >>>> + ---help--- >>>> + If you want to be able to attach gdb to Xen to be able to debug >>>> + Xen if it crashes then say Y. >>>> + >>>> config DEBUG >>>> bool "Developer Checks" >>>> ---help--- >>> >>> Is this really meant to be independent of DEBUG (or EXPERT), as it's >>> being placed ahead of DEBUG? >> >> That's what we talked about with v2. You wanted it to be independent i= f >> EXPERT was set but when you have something defined as "menuconfig XXXX= " >> you cannot then have a rule "if XXXX || EXPERT" as you asked for in v2= =2E >> So I needed to make them independent always which is what I did. >> >> Let me restate more generically, if things are dependent on a menu for= >> the sub-menu items to be displayed (as in v2) then the menu must be >> enabled and cannot be conditionally displayed on another option. >> >> Roughly think of it this way: >> >> menuconfig SOME_STATE >> >> if SOME_STATE || EXPERT >> >> config OTHER >> >> endif >> >> >> is the following code: >> >> >> if (SOME_STATE) { >> if (SOME_STATE or EXPERT) { >> printf("got here\n"); >> } >> } >=20 > But there's no menuconfig anymore, for precisely that reason (aiui). >=20 > Jan >=20 Right. That's what I was trying to get across. What I gathered from past reviews is that it should to be independent of DEBUG correct? --=20 Doug Goldstein --xW9DapSNtMgmT0AoGDWI2lm0DgDFrncaU-- --xqiq8agdpPigl4ARjJhJFaUo3bJIv1aa8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJXO9BdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUOzkQAJNBdR82BvOD0+MN2shS4TtL PgN+EtMfCHI16XBu8lutm1g5zJkK3eJ7PBNeSGoBJlC0y1vudFFCt9FkrHJzySwQ +NilmXIqiWm/Wer6izVkQ+qu0RUQrqvSV4h6dTNcZYZ1JbgrOTofhUkMyT31Y8sW XGftZ8jV8Syj0pogOn8DBHhieJDiRN+xruL2QCR7gFjLoM7lbRH/37lFx+qlQE97 qhrvYmO858FiX4bMvc6OK3h7LZQOK66uUT2B3LMFXc7B77IlRdsQe6a7rYp4GrG7 lJary7vTrkCowL/KvDEobb7QBshhVGh5xhr91tfetaqMJKdSXLs5IrIu0/3aediG TDgoXl4yh7Mg/8JOtWitReLFC/idCkhekyNXd8S0XH+E1VnruXKfulXV6q4zY6N7 PyKNixo7AAG28JZE0WfLUKitp4bGtmo2HSio8+r5kfMA0lEy+xllcYVOxPSYZKUM kLSYfm7nOXQOYLbshlxmPYuAcsyONIXX+AYvgNZ9kaCgZ3HEcwaUXG9oNT48Pgw0 /ZgFmZb56gnRpBbNVjWnS4DZR/BwiN4d0XMerbrqlncsc1hnWBOnrDOM5ZInfQX/ 7LrvO7lY22zgVRG0cMLBF8dOXfWeyxpV+PfBcSD7wW1TzcDyxgzs1Bu5PH5OUP8e 862MpeFVtylOpPCralnV =QIfy -----END PGP SIGNATURE----- --xqiq8agdpPigl4ARjJhJFaUo3bJIv1aa8-- --===============7963374280159993018== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7963374280159993018==--