From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH 00/16] x86/vm-event: numerous adjustments & fixes Date: Mon, 11 Jul 2016 08:32:06 +0300 Message-ID: <454ba37d-384a-205f-25f8-007eaa10124a@bitdefender.com> References: <1468037509-6428-1-git-send-email-czuzu@bitdefender.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4620698212178414127==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "Tian, Kevin" , "xen-devel@lists.xen.org" Cc: Stefano Stabellini , Jan Beulich , Razvan Cojocaru , George Dunlap , Andrew Cooper , Julien Grall , Paul Durrant , Tamas K Lengyel , "Nakajima, Jun" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============4620698212178414127== Content-Type: multipart/alternative; boundary="------------66DF6177C738E068F0A34AF9" This is a multi-part message in MIME format. --------------66DF6177C738E068F0A34AF9 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 7/11/2016 5:54 AM, Tian, Kevin wrote: > what's the difference between this series and earlier one? > > [PATCH v3 0/8] x86/vm-event: Adjustments & fixes > > looks you have some patches cross-posted (e.g. 1/16)... > >> Corneliu ZUZU (16): >> x86/vmx_update_guest_cr: minor optimization >> x86: fix: make atomic_read() param const >> x86/monitor: mechanical renames >> x86/monitor: relocate vm_event_register_write_resume() function to >> monitor code >> x86/monitor: relocate code more appropriately >> x86/monitor: fix: set msr_bitmap to NULL after xfree >> x86/vm-event: fix: call cleanup when init fails, to free partial >> allocs >> x86/vm-event: call monitor init & cleanup funcs from respective >> vm_event funcs >> arm/monitor: move d->monitor cleanup to monitor_cleanup_domain() >> x86/vm-event: centralize vcpu-destroy cleanup in vm-events code >> x86/monitor: fix: treat -monitor- properly, as a subsys of the >> vm-event subsys >> x86/vm-event: fix: move cleanup of mem_access_emulate_each_rep to >> monitor stub >> x86/monitor: introduce writes_pending field in monitor_write_data >> x86/monitor: clarify separation between monitor subsys and vm-event as >> a whole >> x86/monitor: fix: don't compromise a monitor_write_data with pending >> CR writes >> x86/monitor: fix: xc_monitor _write_ctrlreg w/o previous _enable must >> fail >> >> -- >> 2.5.0 > Hi Kevin, I'm sorry about the confusion, the _older v3 series is superseded by this 16-patches one_. I thought the latter was too complex to consider as a v4 over the former, but I should have at least stated something to lead you guys to that conclusion (and to specify changes..). The patches that are still in this series from the older one, the changes and the acks are as following: - P 1/16, was 1/8 in v3 * changed since v3: nothing * acked-by in old v3: Acked-by: Kevin Tian - P 5/16, was 2/8 in v3 * changed since v3: - title slightly changed - renames due to 3/16: arch_monitor_write_data()->monitor_ctrlreg_write_data(), write_ctrlreg_adjust_traps()->monitor_ctrlreg_adjust_traps(), write_ctrlreg_disable_traps()->monitor_ctrlreg_disable_traps() - added 'const' attribute to "struct *domain" param of vmx_vm_event_update_cr3_traps - 'index' param of monitor_ctrlreg_adjust_traps now of type 'unsigned int' * acked-by in old v3: no-one - P 15/16, was 3/8 in v3: * changed since v3 (IMO changes are too many and depends on previous patches in this 16-p-series and it would be better if the old v3 one is simply forgotten-about): - separated fields in arch_vm_event in another structure and arch_vm_event only holds a pointer to that struct (arch_vm_event->monitor->...) - see 14/16 for details - arch_vm_event.monitor freed entirely when the pending writes are committed (monitor_ctrlreg_write_data()) or when the domain/vcpu is destroyed * acked-by in old v3: no-one - P 16/16, was 4/8 in v3: * changed since v3: use ENODEV error code instead of ENOSYS * acked-by in old v3: no-one The rest of patches in v3 (P5-P8) already made it to staging. Sorry again and thanks, Zuzu C. --------------66DF6177C738E068F0A34AF9 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit
On 7/11/2016 5:54 AM, Tian, Kevin wrote:
what's the difference between this series and earlier one?

[PATCH v3 0/8] x86/vm-event: Adjustments & fixes

looks you have some patches cross-posted (e.g. 1/16)...


Corneliu ZUZU (16):
  x86/vmx_update_guest_cr: minor optimization
  x86: fix: make atomic_read() param const
  x86/monitor: mechanical renames
  x86/monitor: relocate vm_event_register_write_resume() function to
    monitor code
  x86/monitor: relocate code more appropriately
  x86/monitor: fix: set msr_bitmap to NULL after xfree
  x86/vm-event: fix: call cleanup when init fails, to free partial
    allocs
  x86/vm-event: call monitor init & cleanup funcs from respective
    vm_event funcs
  arm/monitor: move d->monitor cleanup to monitor_cleanup_domain()
  x86/vm-event: centralize vcpu-destroy cleanup in vm-events code
  x86/monitor: fix: treat -monitor- properly, as a subsys of the
    vm-event subsys
  x86/vm-event: fix: move cleanup of mem_access_emulate_each_rep to
    monitor stub
  x86/monitor: introduce writes_pending field in monitor_write_data
  x86/monitor: clarify separation between monitor subsys and vm-event as
    a whole
  x86/monitor: fix: don't compromise a monitor_write_data with pending
    CR writes
  x86/monitor: fix: xc_monitor _write_ctrlreg w/o previous _enable must
    fail

--
2.5.0

Hi Kevin,

I'm sorry about the confusion, the _older v3 series is superseded by this 16-patches one_. I thought the latter was too complex to consider as a v4 over the former, but I should have at least stated something to lead you guys to that conclusion (and to specify changes..). The patches that are still in this series from the older one, the changes and the acks are as following:

- P 1/16, was 1/8 in v3
    * changed since v3: nothing
    * acked-by in old v3: Acked-by: Kevin Tian <kevin.tian@intel.com>

- P 5/16, was 2/8 in v3
    * changed since v3:
        - title slightly changed
        - renames due to 3/16: arch_monitor_write_data()->monitor_ctrlreg_write_data(), write_ctrlreg_adjust_traps()->monitor_ctrlreg_adjust_traps(), write_ctrlreg_disable_traps()->monitor_ctrlreg_disable_traps()
        - added 'const' attribute to "struct *domain" param of vmx_vm_event_update_cr3_traps
        - 'index' param of monitor_ctrlreg_adjust_traps now of type 'unsigned int'
    * acked-by in old v3: no-one

- P 15/16, was 3/8 in v3:
     * changed since v3 (IMO changes are too many and depends on previous patches in this 16-p-series and it would be better if the old v3 one is simply forgotten-about):
        - separated fields in arch_vm_event in another structure and arch_vm_event only holds a pointer to that struct (arch_vm_event->monitor->...) - see 14/16 for details
        - arch_vm_event.monitor freed entirely when the pending writes are committed (monitor_ctrlreg_write_data()) or when the domain/vcpu is destroyed
     * acked-by in old v3: no-one

- P 16/16, was 4/8 in v3:
     * changed since v3: use ENODEV error code instead of ENOSYS
     * acked-by in old v3: no-one

The rest of patches in v3 (P5-P8) already made it to staging.

Sorry again and thanks,
Zuzu C.
--------------66DF6177C738E068F0A34AF9-- --===============4620698212178414127== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============4620698212178414127==--