From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23233C433E0 for ; Thu, 28 Jan 2021 13:18:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AABD564DD8 for ; Thu, 28 Jan 2021 13:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AABD564DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.77033.139299 (Exim 4.92) (envelope-from ) id 1l57C7-0006HQ-OA; Thu, 28 Jan 2021 13:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 77033.139299; Thu, 28 Jan 2021 13:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l57C7-0006HJ-Jy; Thu, 28 Jan 2021 13:18:43 +0000 Received: by outflank-mailman (input) for mailman id 77033; Thu, 28 Jan 2021 13:18:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l57C6-0006HE-90 for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 13:18:42 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b70bd841-e873-44a7-b358-995716f89a35; Thu, 28 Jan 2021 13:18:41 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F046AEA3; Thu, 28 Jan 2021 13:18:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b70bd841-e873-44a7-b358-995716f89a35 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611839920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LYkPWHaKhct+1v5Sml7YnuqAcl/k0wQI/BCN2u6qWXU=; b=JTR9AzIAcu8tChFF14Gbx1GrP2Jy8wn4byWwyRSOX5Kt4QXnDXteso2FgPg4FPoSF7O2Xh 9wramTtz1xmPjzlHk/P4ic0VL9JLrZT9S788r20e/C3x/WS8BSYarLADDSHyofdg88KnSS Pd2iQJwviYkb0YQ7o4K0wSNhJ8c8xZU= Subject: Re: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling common To: Oleksandr Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Daniel De Graaf , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-10-git-send-email-olekstysh@gmail.com> <19fa20ec-739b-250a-19f5-c4cbafd632fa@gmail.com> From: Jan Beulich Message-ID: <46d8a845-8cbc-365b-1032-f079bf1e7d67@suse.com> Date: Thu, 28 Jan 2021 14:18:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <19fa20ec-739b-250a-19f5-c4cbafd632fa@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 28.01.2021 13:06, Oleksandr wrote: > > On 28.01.21 12:52, Jan Beulich wrote: > > Hi Jan > >> On 25.01.2021 20:08, Oleksandr Tyshchenko wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/dm.h >>> @@ -0,0 +1,41 @@ >>> +/* >>> + * Copyright (c) 2016 Citrix Systems Inc. >>> + * >>> + * This program is free software; you can redistribute it and/or modify it >>> + * under the terms and conditions of the GNU General Public License, >>> + * version 2, as published by the Free Software Foundation. >>> + * >>> + * This program is distributed in the hope it will be useful, but WITHOUT >>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >>> + * more details. >>> + * >>> + * You should have received a copy of the GNU General Public License along with >>> + * this program; If not, see . >>> + */ >>> + >>> +#ifndef __XEN_DM_H__ >>> +#define __XEN_DM_H__ >>> + >>> +#include >>> + >>> +struct dmop_args { >>> + domid_t domid; >>> + unsigned int nr_bufs; >>> + /* Reserve enough buf elements for all current hypercalls. */ >>> + struct xen_dm_op_buf buf[2]; >> So this is then the patch where the public header needs including, >> to satisfy this use of a struct declared there independent of what >> xen/sched.h includes. In fact public/xen.h needs including here >> as well, I think, for domid_t. Otoh I can't see why you include >> xen/sched.h. > > Yes, xen/sched.h indeed doesn't need to be included here, I mentioned > that we could just replace > > it by xen/types.h (this is the minimum what we need here I think). As I > understand public/xen.h is already included by public/hvm/dm_op.h... But that's something you better wouldn't depend on anywhere. What one public header does or does not include may change over time. Jan