From: Jan Beulich <jbeulich@suse.com>
To: "Petr Beneš" <w1benny@gmail.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/7] x86/p2m: Add braces for better code clarity
Date: Thu, 25 Apr 2024 08:21:49 +0200 [thread overview]
Message-ID: <470e0d7a-918b-4df6-a7b2-e8ee2d98dbde@suse.com> (raw)
In-Reply-To: <2e6e4f07b9e8f50ae65697c8644995aa4851cdac.1713990376.git.w1benny@gmail.com>
On 24.04.2024 22:41, Petr Beneš wrote:
> From: Petr Beneš <w1benny@gmail.com>
>
> No functional change.
>
> Signed-off-by: Petr Beneš <w1benny@gmail.com>
Hmm. I don't really mind the extra braces, but I also don't really see a need.
IOW this is not an objection, but it'll want to be someone else (if anyone) to
ack this.
Jan
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -106,6 +106,7 @@ void p2m_change_entry_type_global(struct domain *d,
> unsigned int i;
>
> for ( i = 0; i < MAX_ALTP2M; i++ )
> + {
> if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> {
> struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> @@ -114,6 +115,7 @@ void p2m_change_entry_type_global(struct domain *d,
> change_entry_type_global(altp2m, ot, nt);
> p2m_unlock(altp2m);
> }
> + }
> }
>
> p2m_unlock(hostp2m);
> @@ -139,6 +141,7 @@ void p2m_memory_type_changed(struct domain *d)
> unsigned int i;
>
> for ( i = 0; i < MAX_ALTP2M; i++ )
> + {
> if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
> {
> struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
> @@ -147,6 +150,7 @@ void p2m_memory_type_changed(struct domain *d)
> _memory_type_changed(altp2m);
> p2m_unlock(altp2m);
> }
> + }
> }
>
> p2m_unlock(hostp2m);
next prev parent reply other threads:[~2024-04-25 6:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 20:41 [PATCH 0/7] x86: Make MAX_ALTP2M configurable Petr Beneš
2024-04-24 20:41 ` [PATCH 1/7] x86/p2m: Add braces for better code clarity Petr Beneš
2024-04-25 6:21 ` Jan Beulich [this message]
2024-04-25 8:41 ` Petr Beneš
2024-04-25 23:38 ` Stefano Stabellini
2024-04-24 20:42 ` [PATCH 2/7] x86/hap: Refactor boolean field assignments Petr Beneš
2024-04-25 6:22 ` Jan Beulich
2024-04-24 20:42 ` [PATCH 3/7] tools/xl: Add max_altp2m parameter Petr Beneš
2024-04-25 6:19 ` Jan Beulich
2024-04-25 8:51 ` Petr Beneš
2024-04-25 9:56 ` Jan Beulich
2024-04-24 20:42 ` [PATCH 4/7] tools/ocaml: " Petr Beneš
2024-04-25 8:53 ` Christian Lindig
2024-04-24 20:42 ` [PATCH 5/7] docs/man: Add max_altp2m parameter to the xl.cfg manual Petr Beneš
2024-04-24 20:42 ` [PATCH 6/7] x86: Make the maximum number of altp2m views configurable Petr Beneš
2024-04-24 20:42 ` [PATCH 7/7] x86/hap: Increase the number of initial mempool_size to 1024 pages Petr Beneš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470e0d7a-918b-4df6-a7b2-e8ee2d98dbde@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=roger.pau@citrix.com \
--cc=w1benny@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).