* [PATCH][4.15?] libxl/ACPI: add missing build dependency
@ 2021-03-05 16:28 Jan Beulich
2021-03-05 16:34 ` Ian Jackson
2021-03-05 16:50 ` Andrew Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2021-03-05 16:28 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, Anthony Perard
Just like all other object files - wherever *.o is mentioned, *.opic
also needs mentioning to yield consistent behavior. Otherwise make may
decide to (re)build the object before recursion into $(ACPI_PATH)/ (to
update $(DSDT_FILES-y) and ssdt_*.h) was actually finished.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
A related but separate issue is that build.o* get rebuilt even if none
of their file dependencies changed, merely - aiui - because of their
dependency on the phony "acpi" target. It may be possible to limit this
rebuilding by making both depend on $(DSDT_FILES-y) instead, but then
they would still get rebuilt for no reason when that file (if any)
changed (but ssdt_*.h didn't).
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -32,7 +32,7 @@ ACPI_PATH = $(XEN_ROOT)/tools/libacpi
DSDT_FILES-$(CONFIG_X86) = dsdt_pvh.c
ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES-y)) build.o static_tables.o
ACPI_PIC_OBJS = $(patsubst %.o,%.opic,$(ACPI_OBJS))
-$(DSDT_FILES-y) build.o: acpi
+$(DSDT_FILES-y) build.o build.opic: acpi
vpath build.c $(ACPI_PATH)/
vpath static_tables.c $(ACPI_PATH)/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][4.15?] libxl/ACPI: add missing build dependency
2021-03-05 16:28 [PATCH][4.15?] libxl/ACPI: add missing build dependency Jan Beulich
@ 2021-03-05 16:34 ` Ian Jackson
2021-03-05 16:50 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2021-03-05 16:34 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Wei Liu, Anthony Perard
Jan Beulich writes ("[PATCH][4.15?] libxl/ACPI: add missing build dependency"):
> Just like all other object files - wherever *.o is mentioned, *.opic
> also needs mentioning to yield consistent behavior. Otherwise make may
> decide to (re)build the object before recursion into $(ACPI_PATH)/ (to
> update $(DSDT_FILES-y) and ssdt_*.h) was actually finished.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][4.15?] libxl/ACPI: add missing build dependency
2021-03-05 16:28 [PATCH][4.15?] libxl/ACPI: add missing build dependency Jan Beulich
2021-03-05 16:34 ` Ian Jackson
@ 2021-03-05 16:50 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2021-03-05 16:50 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Jackson, Wei Liu, Anthony Perard
On 05/03/2021 16:28, Jan Beulich wrote:
> Just like all other object files - wherever *.o is mentioned, *.opic
> also needs mentioning to yield consistent behavior. Otherwise make may
> decide to (re)build the object before recursion into $(ACPI_PATH)/ (to
> update $(DSDT_FILES-y) and ssdt_*.h) was actually finished.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-05 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 16:28 [PATCH][4.15?] libxl/ACPI: add missing build dependency Jan Beulich
2021-03-05 16:34 ` Ian Jackson
2021-03-05 16:50 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).