From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29339C3F68F for ; Tue, 11 Feb 2020 10:08:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFAB32086A for ; Tue, 11 Feb 2020 10:08:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFAB32086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1SSD-0002q4-TK; Tue, 11 Feb 2020 10:07:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j1SSC-0002pz-NL for xen-devel@lists.xenproject.org; Tue, 11 Feb 2020 10:07:40 +0000 X-Inumbo-ID: 55d154a4-4cb6-11ea-b54d-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 55d154a4-4cb6-11ea-b54d-12813bfff9fa; Tue, 11 Feb 2020 10:07:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 97E8CAE54; Tue, 11 Feb 2020 10:07:37 +0000 (UTC) Message-ID: <4a22b68a38e2198c3747f9da2a86d72af2d82e7b.camel@suse.com> From: Dario Faggioli To: =?ISO-8859-1?Q?J=FCrgen_Gro=DF?= , xen-devel@lists.xenproject.org Date: Tue, 11 Feb 2020 11:07:36 +0100 In-Reply-To: References: <20200210164533.29549-1-jgross@suse.com> <042afa6eee4bc8e9316e636bf30f0a2190f7ee11.camel@suse.com> Organization: SUSE User-Agent: Evolution 3.34.3 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap Content-Type: multipart/mixed; boundary="===============2271151525795094830==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============2271151525795094830== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-MW3clZOP26fVrw7a7Q0Y" --=-MW3clZOP26fVrw7a7Q0Y Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-02-11 at 10:36 +0100, J=C3=BCrgen Gro=C3=9F wrote: > On 11.02.20 10:29, Dario Faggioli wrote: > >=20 > > TBH, though, considering the nature of the check, I'd rather keep > > the > > ASSERT() and kill the BUG_ON(). > >=20 > > I can do the patch myself if you don't want to respin it that way. >=20 > I'll respin. > Thanks! On an not so related note... I have that other patch of yours, the one about Credit2 runqueues on my list. Sorry it's taking a while to review it properly. I'll try to get to it ASAP. Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-MW3clZOP26fVrw7a7Q0Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl5CfOgACgkQFkJ4iaW4 c+5pOQ/+P3wEF7jdBOhHbRBeR90NIGY6uoZHyQ/K7xxXgDFqzkxZlzQUqC/78ljb lqVvxGY8cH+Zfg9TgzKpGE+HgNpoSGHZbF6b1UIwJp3fvdSDBkkxIKgobwto27Sz uIFAA7GtBVw44kod/rFdshB9AJMQzsFugDmX9qiqETsxN/boqFK3fcFGLNNo8xOo fFB7FZOg8aMbe1xsgHlIUvxYpQAfpxaOQb9LwCu4AOSIftrJR6T+FEU0oZKm3VXl IbYMqM/F1CjBYYu+sMpe7zZhvgv5dOsIg1CtkC3tWMgD2+f0pTsuuXsHURk70bQu SiYwZQJr6+89dO/jnftkKoQ1EwfVaZLNDBR69TBZVvD6R1dAgG3Hv+6Y8CiD5cDd Hw5Ufwm1pdRUZ9zxH/3oMX9/EmgV+05m6aVd5IoADa7espdmGlQ8BACpYoyDLr+M WQGVvIN7orTFnfxkI1wSWqqHzanLVLBRMvhyQWzj36RMNxiKokw7ffHrSm3SNh69 tQK3S8dqvIll7UYha6V43FBu/YDTz8Y/f1DYyOIVHWu2CQXji2Zv55gatngwwPAS F1LiEtYuiAKiHSqHegtqb66rdVc8VfPIMQcmQMlyq0PRu713oc+Oefqj9Dh6ojuC GB0gH4/Tb3uAvlNCiVbLs98a/OrquRIHEk2lRnDTK31bB4TaF4w= =acPh -----END PGP SIGNATURE----- --=-MW3clZOP26fVrw7a7Q0Y-- --===============2271151525795094830== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============2271151525795094830==--