From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3DBC433DF for ; Wed, 26 Aug 2020 08:28:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26644206FA for ; Wed, 26 Aug 2020 08:28:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26644206FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kAqmV-0005mZ-6R; Wed, 26 Aug 2020 08:27:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kAqmT-0005mU-H5 for xen-devel@lists.xenproject.org; Wed, 26 Aug 2020 08:27:41 +0000 X-Inumbo-ID: 00300f24-5dbb-4dc6-88a5-363641648b7e Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 00300f24-5dbb-4dc6-88a5-363641648b7e; Wed, 26 Aug 2020 08:27:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2FB35AD29; Wed, 26 Aug 2020 08:28:11 +0000 (UTC) Subject: Re: [PATCH 2/2] arm/xen: Add misuse warning to virt_to_gfn To: Simon Leiner , Jan Beulich , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, julien@xen.org References: <20200825093153.35500-1-simon@leiner.me> <20200825093153.35500-2-simon@leiner.me> <374f42a0-b618-8b90-71b5-0a865ea1ddbb@suse.com> <00bdd0ee-8f18-4580-01c7-01c95f3a6184@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <4a86bc25-e6b0-0a6d-b5ee-fcdac49415d1@suse.com> Date: Wed, 26 Aug 2020 10:27:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 26.08.20 10:14, Simon Leiner wrote: > On 26.08.20 09:59, Jürgen Groß wrote: >> This seems to be an Arm specific function. > > Is that a problem? The caller site is also ARM specific. The caller site is ARM specific, but __is_lm_address() is defined for arm64 only. > >> virt_addr_valid() seems to be a good fit. > > If you prefer that anyway, I will change it and resubmit that part of > the patch. No need for resend, I can fix that when committing. Juergen