From: "Yu, Zhang" <yu.c.zhang@linux.intel.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org, Paul.Durrant@citrix.com,
zhiyuan.lv@intel.com, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v3 2/3] x86/ioreq server: Add new functions to get/set memory types.
Date: Wed, 27 Apr 2016 17:11:56 +0800 [thread overview]
Message-ID: <4b7568fb-f720-7a65-d18e-0321361d0e70@linux.intel.com> (raw)
In-Reply-To: <20160426105331.GG20763@citrix.com>
On 4/26/2016 6:53 PM, Wei Liu wrote:
> Hi Yu
>
> On Mon, Apr 25, 2016 at 06:35:39PM +0800, Yu Zhang wrote:
>> For clarity this patch breaks the code to set/get memory types out
>> of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type().
>> Also, for clarity, checks for whether a memory type change is allowed
>> are broken out into a separate function called by hvmop_set_mem_type().
>>
>> There is no intentional functional change in this patch.
>>
>> changes in v3:
>> - Add Andrew's Acked-by and George's Reviewed-by.
>>
>> changes in v2:
>> - According to George Dunlap's comments, follow the "set rc /
>> do something / goto out" pattern in hvmop_get_mem_type().
>>
>
> Normally we put these changelogs (or other information that is not
> intended to be committed) between "---" so that they are ignored
> when committing. Here is one example:
>
> https://marc.info/?l=xen-devel&m=146056699332101
>
> Note the Cc and some extra words inside surrounded by two "---". They
> will be ignored when committing.
>
Oh. Thanks for your information, Wei. :)
B.R.
Yu
> The code itself looks good to me.
>
> Wei.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-27 9:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 10:35 [PATCH v3 0/3] x86/ioreq server: Introduce HVMMEM_ioreq_server mem type Yu Zhang
2016-04-25 10:35 ` [PATCH v3 1/3] x86/ioreq server(patch for 4.7): Rename p2m_mmio_write_dm to p2m_ioreq_server Yu Zhang
2016-04-25 12:12 ` Jan Beulich
2016-04-25 13:30 ` Wei Liu
2016-04-25 13:39 ` George Dunlap
2016-04-25 14:01 ` Paul Durrant
2016-04-25 14:15 ` George Dunlap
2016-04-25 14:16 ` Jan Beulich
2016-04-25 14:19 ` Paul Durrant
2016-04-25 14:28 ` George Dunlap
2016-04-25 14:34 ` Paul Durrant
2016-04-25 15:21 ` Yu, Zhang
2016-04-25 15:29 ` Paul Durrant
2016-04-25 15:38 ` Jan Beulich
2016-04-25 15:53 ` Yu, Zhang
2016-04-25 16:15 ` George Dunlap
2016-04-25 16:20 ` Yu, Zhang
2016-04-25 17:01 ` Paul Durrant
2016-04-26 8:23 ` Yu, Zhang
2016-04-26 8:33 ` Paul Durrant
2016-04-27 14:12 ` George Dunlap
2016-04-27 14:42 ` Paul Durrant
2016-04-28 2:47 ` Yu, Zhang
2016-04-28 7:14 ` Paul Durrant
2016-04-28 7:07 ` Yu, Zhang
2016-04-28 10:02 ` Jan Beulich
2016-04-28 10:43 ` Paul Durrant
2016-04-27 14:47 ` Wei Liu
2016-04-25 15:49 ` Yu, Zhang
2016-04-25 14:14 ` Jan Beulich
2016-04-25 10:35 ` [PATCH v3 2/3] x86/ioreq server: Add new functions to get/set memory types Yu Zhang
2016-04-26 10:53 ` Wei Liu
2016-04-27 9:11 ` Yu, Zhang [this message]
2016-04-25 10:35 ` [PATCH v3 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server Yu Zhang
2016-04-25 12:36 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7568fb-f720-7a65-d18e-0321361d0e70@linux.intel.com \
--to=yu.c.zhang@linux.intel.com \
--cc=Paul.Durrant@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).