From: Nick Rosbrook <rosbrookn@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: george.dunlap@citrix.com, Nick Rosbrook <rosbrookn@ainfosec.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: [RFC v2 3/7] libxl: add PASS_BY_CONST_REFERENCE to idl
Date: Tue, 2 Mar 2021 20:46:15 -0500 [thread overview]
Message-ID: <4b7f52dd28516aa286ab6db90536835b8caed022.1614734296.git.rosbrookn@ainfosec.com> (raw)
In-Reply-To: <cover.1614734296.git.rosbrookn@ainfosec.com>
In-Reply-To: <cover.1614734296.git.rosbrookn@ainfosec.com>
Currently, there is only support for PASS_BY_{REFERENCE,VALUE} in the IDL.
As a piece of adding function support, add logic for PASS_BY_CONST_REFERENCE
so that function generation code can use Type.make_arg() for function
signatures that require const reference parameters.
Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
---
tools/libs/light/idl.py | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/libs/light/idl.py b/tools/libs/light/idl.py
index 20278c272a..a8a4768efc 100644
--- a/tools/libs/light/idl.py
+++ b/tools/libs/light/idl.py
@@ -4,6 +4,7 @@ import sys
PASS_BY_VALUE = 1
PASS_BY_REFERENCE = 2
+PASS_BY_CONST_REFERENCE = 3
DIR_NONE = 0
DIR_IN = 1
@@ -40,7 +41,7 @@ class Type(object):
raise ValueError
self.passby = kwargs.setdefault('passby', PASS_BY_VALUE)
- if self.passby not in [PASS_BY_VALUE, PASS_BY_REFERENCE]:
+ if self.passby not in [PASS_BY_VALUE, PASS_BY_REFERENCE, PASS_BY_CONST_REFERENCE]:
raise ValueError
self.private = kwargs.setdefault('private', False)
@@ -109,6 +110,8 @@ class Type(object):
if passby == PASS_BY_REFERENCE:
return "%s *%s" % (self.typename, n)
+ elif passby == PASS_BY_CONST_REFERENCE:
+ return "const %s *%s" % (self.typename, n)
else:
return "%s %s" % (self.typename, n)
@@ -116,7 +119,7 @@ class Type(object):
if passby is None: passby = self.passby
if isref is None: isref = self.passby == PASS_BY_REFERENCE
- if passby == PASS_BY_REFERENCE:
+ if passby in [PASS_BY_REFERENCE, PASS_BY_CONST_REFERENCE]:
if isref:
return "%s" % (n)
else:
@@ -272,7 +275,7 @@ class KeyedUnion(Aggregate):
raise ValueError
kv_kwargs = dict([(x.lstrip('keyvar_'),y) for (x,y) in kwargs.items() if x.startswith('keyvar_')])
-
+
self.keyvar = Field(keyvar_type, keyvar_name, **kv_kwargs)
for f in fields:
@@ -392,6 +395,7 @@ def parse(f):
elif isinstance(t,type(object)) and issubclass(t, Function):
globs[n] = t
elif n in ['PASS_BY_REFERENCE', 'PASS_BY_VALUE',
+ 'PASS_BY_CONST_REFERENCE',
'DIR_NONE', 'DIR_IN', 'DIR_OUT', 'DIR_BOTH',
'namespace', 'hidden']:
globs[n] = t
--
2.17.1
next prev parent reply other threads:[~2021-03-03 1:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:46 [RFC v2 0/7] add function support to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 1/7] libxl: remove extra whitespace from gentypes.py Nick Rosbrook
2021-05-04 14:39 ` Anthony PERARD
2021-03-03 1:46 ` [RFC v2 2/7] libxl: add Function class to IDL Nick Rosbrook
2021-03-03 1:46 ` Nick Rosbrook [this message]
2021-03-03 1:46 ` [RFC v2 4/7] libxl: add DeviceFunction classes " Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 5/7] libxl: add device function definitions to libxl_types.idl Nick Rosbrook
2021-05-04 15:43 ` Anthony PERARD
2021-05-04 17:26 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 6/7] libxl: implement device add/remove/destroy functions generation Nick Rosbrook
2021-05-04 15:02 ` Anthony PERARD
2021-05-04 17:29 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 7/7] libxl: replace LIBXL_DEFINE_DEVICE* macro usage with generated code Nick Rosbrook
2021-03-03 9:48 ` [RFC v2 0/7] add function support to IDL Ian Jackson
2021-03-03 13:41 ` Nick Rosbrook
2021-04-21 21:28 ` Nick Rosbrook
2021-05-04 15:46 ` Anthony PERARD
2021-05-04 17:31 ` Nick Rosbrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b7f52dd28516aa286ab6db90536835b8caed022.1614734296.git.rosbrookn@ainfosec.com \
--to=rosbrookn@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=rosbrookn@ainfosec.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).