From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 740F0C433F1 for ; Fri, 24 Jul 2020 19:09:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ACAB2070B for ; Fri, 24 Jul 2020 19:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Qg+gbYYs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ACAB2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jz33y-0000eH-S7; Fri, 24 Jul 2020 19:08:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jz33w-0000eC-S2 for xen-devel@lists.xenproject.org; Fri, 24 Jul 2020 19:08:56 +0000 X-Inumbo-ID: 1ec7a93e-cde1-11ea-8883-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1ec7a93e-cde1-11ea-8883-bc764e2007e4; Fri, 24 Jul 2020 19:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1595617735; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=dTA0AOHWB+wTsIepH5Uey9aBnWll55Pv73riAbQys/o=; b=Qg+gbYYsdly0/7wU0C/VjP42rdACOZr2tR5rmcZLpgfeyWoT4qLyFUus mCPsCW3v/1pM3QSqyMlyryE7g5aXZPKVN/m1cGZJxgVq7qHA0hLh1JGU1 jJfTX/FCvOegkUUqSkkS1iPFF2XTWQJmXrbnMwhZ6U/JMCSmFnB+FPNtb U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: G3N7AlhAc81cS/Q9iEDUhqxMnV1QBOYHf8RzEmgcTnjRWgNEKZxUx4U2hPDg066V2lzN6fX6qZ C+9RZRyd8gGdRqxOK+FzIlAROqBnLpvkyiHl49iLAs6hMlkMIwi8xj0K++HKy8X1gwaFI7p3hS kx17EbbajiMsMvHVk7FR4NbbFTwbH+eniPU3RkCEFEtAJH2DFbCjKJ2Km32n38Y2zO3/djQmOx 82IzmhbIvDIAu9liFecI1x5lzvAJBFoP6rArMbQsikPaq7LrKAyo8hyslQELfbGTNqanW0W5LS GKM= X-SBRS: 2.7 X-MesageID: 23346714 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,391,1589256000"; d="scan'208";a="23346714" Subject: Re: [PATCH 6/6] iommu: stop calling IOMMU page tables 'p2m tables' To: Paul Durrant , References: <20200724164619.1245-1-paul@xen.org> <20200724164619.1245-7-paul@xen.org> From: Andrew Cooper Message-ID: <4e1c2ed8-dfc4-812b-d341-04bc5eedad8e@citrix.com> Date: Fri, 24 Jul 2020 20:08:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200724164619.1245-7-paul@xen.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Kevin Tian , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 24/07/2020 17:46, Paul Durrant wrote: > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c > index 6a3803ff2c..5bc190bf98 100644 > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -535,12 +535,12 @@ static void iommu_dump_p2m_table(unsigned char key) > > if ( iommu_use_hap_pt(d) ) > { > - printk("\ndomain%d IOMMU p2m table shared with MMU: \n", d->domain_id); > + printk("%pd: IOMMU page tables shared with MMU\n", d); Change MMU to CPU?  MMU is very ambiguous in this context. > continue; > } > > - printk("\ndomain%d IOMMU p2m table: \n", d->domain_id); > - ops->dump_p2m_table(d); > + printk("%pd: IOMMU page tables: \n", d); Drop the trailing whitespace? ~Andrew