From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD6CC433DF for ; Mon, 19 Oct 2020 13:47:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6A0D222BA for ; Mon, 19 Oct 2020 13:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="pc7syDGA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6A0D222BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.8712.23339 (Exim 4.92) (envelope-from ) id 1kUVUo-0006mS-TJ; Mon, 19 Oct 2020 13:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 8712.23339; Mon, 19 Oct 2020 13:46:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUVUo-0006mL-QN; Mon, 19 Oct 2020 13:46:42 +0000 Received: by outflank-mailman (input) for mailman id 8712; Mon, 19 Oct 2020 13:46:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUVUn-0006mF-9E for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 13:46:41 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 19610d89-3d32-43b0-af75-7f8cd3222931; Mon, 19 Oct 2020 13:46:40 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 19102B22A; Mon, 19 Oct 2020 13:46:39 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUVUn-0006mF-9E for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 13:46:41 +0000 X-Inumbo-ID: 19610d89-3d32-43b0-af75-7f8cd3222931 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 19610d89-3d32-43b0-af75-7f8cd3222931; Mon, 19 Oct 2020 13:46:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603115199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o3uuDviRWo1QtDtFjPhK/Nzml2kSnSQTZRgY9EKGnbA=; b=pc7syDGASrgxu9p4ycGJlPyBIstMPB88fF1qdLL8pr0c57Qii3W0y/Zxki0PWN8A5aipNq 6ZgRhUIb8Y9ikU0eEKZw193t/kgGQ8IDEEBA9PFujmjbzowlAl9HFmLTlj2uBgM3941OZO 0voeUVVHnEuqJL22B/Nl7ReB4N4ig/U= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 19102B22A; Mon, 19 Oct 2020 13:46:39 +0000 (UTC) Subject: Re: [PATCH v10 01/11] docs / include: introduce a new framework for 'domain context' records To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Paul Durrant , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20201008185735.29875-1-paul@xen.org> <20201008185735.29875-2-paul@xen.org> From: Jan Beulich Message-ID: <4f0b7537-807c-54cc-0c0b-23e30e833f45@suse.com> Date: Mon, 19 Oct 2020 15:46:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201008185735.29875-2-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.10.2020 20:57, Paul Durrant wrote: > --- /dev/null > +++ b/xen/include/public/save.h > @@ -0,0 +1,66 @@ > +/* > + * save.h > + * > + * Structure definitions for common PV/HVM domain state that is held by Xen. > + * > + * Copyright Amazon.com Inc. or its affiliates. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef XEN_PUBLIC_SAVE_H > +#define XEN_PUBLIC_SAVE_H > + > +#if defined(__XEN__) || defined(__XEN_TOOLS__) > + > +#include "xen.h" > + > +/* > + * C structures for the Domain Context v1 format. > + * See docs/specs/domain-context.md > + */ > + > +struct domain_context_record { > + uint32_t type; > + uint32_t instance; > + uint64_t length; Should this be uint64_aligned_t, such that alignof() will produce consistent values regardless of bitness of the invoking domain? Jan