From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Paul Durrant <pdurrant@amazon.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 4/5] common/domain: add a domain context record for shared_info...
Date: Thu, 30 Apr 2020 13:56:02 +0200 [thread overview]
Message-ID: <4f1f401e-2382-1929-407b-37d5a2b64013@suse.com> (raw)
In-Reply-To: <20200407173847.1595-5-paul@xen.org>
On 07.04.2020 19:38, Paul Durrant wrote:
> --- a/tools/misc/xen-domctx.c
> +++ b/tools/misc/xen-domctx.c
> @@ -59,6 +59,16 @@ static void dump_header(struct domain_save_descriptor *desc)
> off += desc->length;
> }
>
> +static void dump_shared_info(struct domain_save_descriptor *desc)
> +{
> + DOMAIN_SAVE_TYPE(SHARED_INFO) s;
> + READ(s);
> + printf(" SHARED_INFO: field_width %u buffer size: %lu\n",
> + s.field_width, desc->length - sizeof(s));
> +
> + off += desc->length;
> +}
And nothing about the actual contents of the shared info struct?
> @@ -1646,6 +1647,86 @@ int continue_hypercall_on_cpu(
> return 0;
> }
>
> +static int save_shared_info(const struct vcpu *v, struct domain_context *c,
> + bool dry_run)
> +{
> + struct domain *d = v->domain;
const?
> + struct domain_shared_info_context ctxt = {};
> + size_t hdr_size = offsetof(typeof(ctxt), buffer);
> + size_t size = hdr_size + PAGE_SIZE;
> + int rc;
> +
> + rc = DOMAIN_SAVE_BEGIN(SHARED_INFO, c, v, size);
> + if ( rc )
> + return rc;
> +
> + if ( !dry_run )
> + ctxt.field_width =
> +#ifdef CONFIG_COMPAT
> + has_32bit_shinfo(d) ? 4 :
> +#endif
> + 8;
What are 4 and 8 to represent here? Taking Arm32 into account, the
only things I could think of are sizeof(xen_ulong_t) or
sizeof(guest_handle). I'd prefer if literal numbers could be avoided
here, such that it would become clear what property is really meant.
> + rc = domain_save_data(c, &ctxt, hdr_size);
> + if ( rc )
> + return rc;
> +
> + rc = domain_save_data(c, d->shared_info, PAGE_SIZE);
> + if ( rc )
> + return rc;
> +
> + return domain_save_end(c);
> +}
> +
> +static int load_shared_info(struct vcpu *v, struct domain_context *c)
> +{
> + struct domain *d = v->domain;
> + struct domain_shared_info_context ctxt = {};
> + size_t hdr_size = offsetof(typeof(ctxt), buffer);
> + size_t size = hdr_size + PAGE_SIZE;
> + unsigned int i;
> + int rc;
> +
> + rc = DOMAIN_LOAD_BEGIN(SHARED_INFO, c, v, size, true);
> + if ( rc )
> + return rc;
> +
> + rc = domain_load_data(c, &ctxt, hdr_size);
> + if ( rc )
> + return rc;
> +
> + for ( i = 0; i < ARRAY_SIZE(ctxt.pad); i++ )
> + if ( ctxt.pad[i] )
> + return -EINVAL;
> +
> + switch ( ctxt.field_width )
> + {
> +#ifdef CONFIG_COMPAT
> + case 4:
> + d->arch.has_32bit_shinfo = 1;
true and ...
> + break;
> +#endif
> + case 8:
> +#ifdef CONFIG_COMPAT
> + d->arch.has_32bit_shinfo = 0;
... false respectively, please.
> +#endif
> + break;
> +
> + default:
> + rc = -EINVAL;
> + break;
> + }
> +
> + rc = domain_load_data(c, d->shared_info, PAGE_SIZE);
> + if ( rc )
> + return rc;
> +
> + return domain_load_end(c);
> +}
While you check the padding fields of the header above, what about
currently unused fields of the shared_info struct itself?
There's a connection between shared_info and vcpu_info - this way
you may or may not restore vcpu_info - depending on guest behavior.
There not being a patch in the series to deal with vcpu_info, the
description here should imo at least outline the intended
interaction (including e.g. ordering between the [supposed] records).
Jan
next prev parent reply other threads:[~2020-04-30 11:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 17:38 [PATCH v2 0/5] domain context infrastructure Paul Durrant
2020-04-07 17:38 ` [PATCH v2 1/5] xen/common: introduce a new framework for save/restore of 'domain' context Paul Durrant
2020-04-20 17:20 ` Julien Grall
2020-04-28 15:35 ` Paul Durrant
2020-04-29 11:05 ` Julien Grall
2020-04-29 11:02 ` Jan Beulich
2020-05-06 16:44 ` Paul Durrant
2020-05-07 7:21 ` Jan Beulich
2020-05-07 7:34 ` Paul Durrant
2020-05-07 7:39 ` Jan Beulich
2020-05-07 7:45 ` Paul Durrant
2020-05-07 8:17 ` Jan Beulich
2020-05-07 8:35 ` Julien Grall
2020-05-07 8:58 ` Jan Beulich
2020-05-07 9:31 ` Julien Grall
2020-04-07 17:38 ` [PATCH v2 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext Paul Durrant
2020-04-20 17:26 ` Julien Grall
2020-04-28 15:36 ` Paul Durrant
2020-04-29 14:50 ` Jan Beulich
2020-05-13 15:06 ` Paul Durrant
2020-04-07 17:38 ` [PATCH v2 3/5] tools/misc: add xen-domctx to present domain context Paul Durrant
2020-04-29 15:04 ` Jan Beulich
2020-05-13 15:27 ` Paul Durrant
2020-04-07 17:38 ` [PATCH v2 4/5] common/domain: add a domain context record for shared_info Paul Durrant
2020-04-20 17:34 ` Julien Grall
2020-04-28 15:37 ` Paul Durrant
2020-04-30 11:29 ` Jan Beulich
2020-04-30 11:56 ` Jan Beulich [this message]
2020-04-07 17:38 ` [PATCH v2 5/5] tools/libxc: make use of domain context SHARED_INFO record Paul Durrant
2020-04-30 11:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1f401e-2382-1929-407b-37d5a2b64013@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).