From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07756C43331 for ; Thu, 26 Mar 2020 15:52:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5C0D20737 for ; Thu, 26 Mar 2020 15:52:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C0D20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHUnQ-0001gS-6n; Thu, 26 Mar 2020 15:51:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jHUnP-0001gN-4W for xen-devel@lists.xenproject.org; Thu, 26 Mar 2020 15:51:51 +0000 X-Inumbo-ID: b47ad1b6-6f79-11ea-8817-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b47ad1b6-6f79-11ea-8817-12813bfff9fa; Thu, 26 Mar 2020 15:51:50 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8000AABF6; Thu, 26 Mar 2020 15:51:49 +0000 (UTC) To: julien@xen.org References: <20200322161418.31606-1-julien@xen.org> <20200322161418.31606-7-julien@xen.org> From: Jan Beulich Message-ID: <4f6d47dd-997d-977e-690d-7f21be2617a0@suse.com> Date: Thu, 26 Mar 2020 16:51:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200322161418.31606-7-julien@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH 06/17] xen/x86: mm: Fix the comment on top put_page_from_l2e() to use 'mfn' X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 22.03.2020 17:14, julien@xen.org wrote: > From: Julien Grall > > We are using the 'mfn' to refer to machine frame. As this function deal > with 'mfn', replace 'pfn' with 'mfn'. > > Signed-off-by: Julien Grall > > --- > > I am not entirely sure to understand the comment on top of the > function, so this change may be wrong. Looking at the history of the function, ... > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1321,7 +1321,7 @@ static int put_data_pages(struct page_info *page, bool writeable, int pt_shift) > } > > /* > - * NB. Virtual address 'l2e' maps to a machine address within frame 'pfn'. > + * NB. Virtual address 'l2e' maps to a machine address within frame 'mfn'. > * Note also that this automatically deals correctly with linear p.t.'s. > */ > static int put_page_from_l2e(l2_pgentry_t l2e, mfn_t l2mfn, unsigned int flags) ... it used to be static int put_page_from_l2e(l2_pgentry_t l2e, unsigned long pfn) When the rename occurred (in the context of or as a follow-up to an XSA iirc), the comment adjustment was apparently missed. With the referenced name matching that of the function argument (l2mfn) Acked-by: Jan Beulich Jan