From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A9BC4363A for ; Mon, 26 Oct 2020 13:31:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0C8D2463C for ; Mon, 26 Oct 2020 13:31:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="M08Fs8Os" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0C8D2463C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.12314.32081 (Exim 4.92) (envelope-from ) id 1kX2bD-0005TX-C9; Mon, 26 Oct 2020 13:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 12314.32081; Mon, 26 Oct 2020 13:31:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kX2bD-0005TQ-8r; Mon, 26 Oct 2020 13:31:47 +0000 Received: by outflank-mailman (input) for mailman id 12314; Mon, 26 Oct 2020 13:31:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kX2bC-0005TL-3r for xen-devel@lists.xenproject.org; Mon, 26 Oct 2020 13:31:46 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24977410-667a-45d5-a7f5-07c358d0e611; Mon, 26 Oct 2020 13:31:45 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kX2bB-0004PW-1m; Mon, 26 Oct 2020 13:31:45 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kX2bA-0005DO-Qs; Mon, 26 Oct 2020 13:31:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kX2bC-0005TL-3r for xen-devel@lists.xenproject.org; Mon, 26 Oct 2020 13:31:46 +0000 X-Inumbo-ID: 24977410-667a-45d5-a7f5-07c358d0e611 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24977410-667a-45d5-a7f5-07c358d0e611; Mon, 26 Oct 2020 13:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=COH07By8MlJXLmXlds6S5U1Em2gVSNaKhuITL1stUJc=; b=M08Fs8OscJP1U4byw5mjknMsbz or7OcQxCp59keMhStF4aMGrG+aE9nNQcwuYRvErF8P+Ua4M3IlMDEcy/jPKr0aIKb3qqlxE3JMzEq 7ZHAt/zgZu37aMVw5olD4n9KTbRIzpcYlpf0GRcpXZyzqsKJQcSLy3Buh2IR1dVeYa6Q=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kX2bB-0004PW-1m; Mon, 26 Oct 2020 13:31:45 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kX2bA-0005DO-Qs; Mon, 26 Oct 2020 13:31:44 +0000 Subject: Re: Xen on RP4 To: Elliott Mitchell , Stefano Stabellini Cc: roman@zededa.com, xen-devel@lists.xenproject.org References: <20201012215751.GB89158@mattapan.m5p.com> <20201016003024.GA13290@mattapan.m5p.com> <23885c28-dee5-4e9a-dc43-6ccf19a94df6@xen.org> <20201022021655.GA74011@mattapan.m5p.com> <20201023005629.GA83870@mattapan.m5p.com> <20201023211941.GA90171@mattapan.m5p.com> <20201024053540.GA97417@mattapan.m5p.com> From: Julien Grall Message-ID: <4fcf4832-9266-443f-54d0-fa1fff4b6e14@xen.org> Date: Mon, 26 Oct 2020 13:31:42 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201024053540.GA97417@mattapan.m5p.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Elliott, On 24/10/2020 06:35, Elliott Mitchell wrote: > On Fri, Oct 23, 2020 at 04:59:30PM -0700, Stefano Stabellini wrote: >> Note that I tried to repro the issue here at my end but it works for me >> with device tree. So the swiotlb_init memory allocation failure probably >> only shows on ACPI, maybe because ACPI is reserving too much low memory. > > Found it. Take a look at 437b0aa06a014ce174e24c0d3530b3e9ab19b18b > > PLATFORM_START(rpi4, "Raspberry Pi 4") > .compatible = rpi4_dt_compat, > .blacklist_dev = rpi4_blacklist_dev, > + .dma_bitsize = 30, > PLATFORM_END > > Where this is used to match against a *device-tree*. Right. When we introduced ACPI in Xen, we made the assumption there would be no need for per-platform workaround. > ACPI has a distinct > means of specifying a limited DMA-width; the above fails, because it > assumes a *device-tree*. Do you know if it would be possible to infer from the ACPI static table the DMA-width? If not, is there a way to uniquely identify the platform? Cheers, -- Julien Grall