From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E80C433ED for ; Tue, 27 Apr 2021 12:30:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE01D61073 for ; Tue, 27 Apr 2021 12:30:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE01D61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.118397.224488 (Exim 4.92) (envelope-from ) id 1lbMrP-0000nJ-R1; Tue, 27 Apr 2021 12:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 118397.224488; Tue, 27 Apr 2021 12:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lbMrP-0000nC-NT; Tue, 27 Apr 2021 12:30:39 +0000 Received: by outflank-mailman (input) for mailman id 118397; Tue, 27 Apr 2021 12:30:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lbMrP-0000n7-5J for xen-devel@lists.xenproject.org; Tue, 27 Apr 2021 12:30:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 918c2e85-20d9-4376-a9a8-13b224a2c90c; Tue, 27 Apr 2021 12:30:37 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9BB3DB19E; Tue, 27 Apr 2021 12:30:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 918c2e85-20d9-4376-a9a8-13b224a2c90c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619526636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+wHkM2KxNMSNO+NMsfMUTi+YRP+pC/vCyyGdQmOYFvM=; b=I5l1GYF5c1RqL++oUVJOBUpx2dXhb1J1so8oX/WlL9z2y/jpNh4giP+EgtrSxv78C2bZ+A uWUynsqJ+r6TO4yo2KPHVZN8LTyay1jL6fl8sVYptrMxQQREmC3gE9vM8WiiG98qPnFIPe DMjYsWfCnH3RT6aZK1rmaTHmDLljEPI= Subject: Re: [PATCH] build: centralize / unify asm-offsets generation To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <5170aa51-8e34-3a45-5bf6-c0a187b1c427@suse.com> From: Jan Beulich Message-ID: <5018479d-b566-a32b-9a01-5ccf01fe0880@suse.com> Date: Tue, 27 Apr 2021 14:30:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 27.04.2021 11:05, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 04:09:03PM +0200, Jan Beulich wrote: >> On 20.04.2021 18:20, Roger Pau Monné wrote: >>> On Tue, Apr 20, 2021 at 05:47:49PM +0200, Jan Beulich wrote: >>>> On 20.04.2021 17:29, Roger Pau Monné wrote: >>>>> On Thu, Apr 01, 2021 at 10:33:47AM +0200, Jan Beulich wrote: >>>>>> @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi >>>>>> @sed -rf tools/process-banner.sed < .banner >> $@.new >>>>>> @mv -f $@.new $@ >>>>>> >>>>>> -include/asm-$(TARGET_ARCH)/asm-offsets.h: arch/$(TARGET_ARCH)/asm-offsets.s >>>>>> +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c >>>>>> + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< >>>>>> + $(call move-if-changed,$@.new,$@) >>>>> >>>>> Won't it be more natural to keep the .s file in arch/$(TARGET_ARCH)? >>>> >>>> Yes and no: Yes as far as the actual file location is concerned. >>>> No when considering where it gets generated: I generally consider >>>> it risky to generate files outside of the directory where make >>>> currently runs. There may be good reasons for certain exceptions, >>>> but personally I don't see this case as good enough a reason. >>>> >>>> Somewhat related - if doing as you suggest, which Makefile's >>>> clean: rule should clean up that file in your opinion? >>> >>> The clean rule should be in the makefile where it's generated IMO, >>> same as asm-offsets.h clean rule currently in xen/Makefile. >>> >>>> Nevertheless, if there's general agreement that keeping the file >>>> there is better, I'd make the change and simply ignore my unhappy >>>> feelings about it. >>> >>> I don't have a strong opinion, it just feels weird to have this IMO >>> stray asm-offsets.s outside of it's arch directory, taking into >>> account that we have asm-offsets.h generated from xen/Makefile into an >>> arch specific directory already as a precedent in that makefile. >> >> Well, asm-offsets.h generation doesn't involve the compiler, hence >> no .*.d files get generated and want including later. For >> asm-offsets.s to have dependencies properly honored, if we >> generated it in xen/arch/, .asm-offsets.d would also end up >> there, and hence including of it would need separately taking care >> of. > > I'm not sure I understand what do you mean with inclusion need taking > care of separately. Isn't it expected for .d file to reside in the > same directory as the output, Yes, ... > and hence picked up automatically? ... and hence they _wouldn't_ be picked up automatically while building in xen/ if the .s file got created in xen/arch//. Jan