From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745DDC43331 for ; Wed, 25 Mar 2020 13:41:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D30920658 for ; Wed, 25 Mar 2020 13:41:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D30920658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH6HO-0003zY-9x; Wed, 25 Mar 2020 13:41:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jH6HN-0003zT-2m for xen-devel@lists.xenproject.org; Wed, 25 Mar 2020 13:41:09 +0000 X-Inumbo-ID: 47a78039-6e9e-11ea-861a-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 47a78039-6e9e-11ea-861a-12813bfff9fa; Wed, 25 Mar 2020 13:41:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A911AC37; Wed, 25 Mar 2020 13:41:07 +0000 (UTC) To: Andrew Cooper References: <20200323101724.15655-1-andrew.cooper3@citrix.com> <20200323101724.15655-5-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <52481e12-eb98-eead-be74-d48815e5a41f@suse.com> Date: Wed, 25 Mar 2020 14:41:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200323101724.15655-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Xen-devel] [PATCH 4/7] x86/ucode/intel: Reimplement get_{data, total}size() helpers X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 23.03.2020 11:17, Andrew Cooper wrote: > Every caller actually passes a struct microcode_header_intel. Implement the > helpers with proper types, and leave a comment explaining the Pentium Pro/II > behaviour with empty {data,total}size fields. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with... > --- a/xen/arch/x86/cpu/microcode/intel.c > +++ b/xen/arch/x86/cpu/microcode/intel.c > @@ -46,9 +46,16 @@ struct microcode_header_intel { > unsigned int sig; > unsigned int cksum; > unsigned int ldrver; > + > + /* > + * Microcode for the Pentium Pro and II had all further fields in the > + * header reserved, had a fixed datasize of 2000 and totalsize of 2048, > + * and didn't use platform flags despite the availability of the MSR. > + */ > + > unsigned int pf; > - unsigned int datasize; > - unsigned int totalsize; > + unsigned int _datasize; > + unsigned int _totalsize; ... the underscores here dropped again. Or else - why did you add them? This (to me at least) doesn't e.g. make any more clear that the fields may be zero on old hardware. Furthermore - do we really need this PPro/PentiumII logic seeing that these aren't 64-bit capable CPUs? Jan