From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA22C433FE for ; Tue, 8 Dec 2020 09:21:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7EC623A7F for ; Tue, 8 Dec 2020 09:21:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7EC623A7F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.47250.83654 (Exim 4.92) (envelope-from ) id 1kmZBE-0006HI-UJ; Tue, 08 Dec 2020 09:21:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 47250.83654; Tue, 08 Dec 2020 09:21:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmZBE-0006HB-RA; Tue, 08 Dec 2020 09:21:08 +0000 Received: by outflank-mailman (input) for mailman id 47250; Tue, 08 Dec 2020 09:21:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmZBD-0006H6-Ai for xen-devel@lists.xenproject.org; Tue, 08 Dec 2020 09:21:07 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 905176cb-45b5-42ab-87bd-e7a7e7ada3ba; Tue, 08 Dec 2020 09:21:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9D946AD12; Tue, 8 Dec 2020 09:21:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 905176cb-45b5-42ab-87bd-e7a7e7ada3ba X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607419265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vBchpSeWtncbpdf+1VsDSWkKrJPN2E5t2O8lWf00Kz8=; b=ngOuN7fz1o9NSqtjW2ns0qn7FLHeGhZq9xr8lqX5yJyS4pYWfrbsfEPoW7f8AdC1SqaBhR cIYaKkkSyTOkutk2Kqp63KjxoQA+qVvSAE+WxBi2x9PYKm26ovr6GoAI6FDHYZVTdTmLjT 3q6a5SRefgezk/7v6UcbBMuxjhNapXg= Subject: Re: [PATCH V3 04/23] xen/ioreq: Make x86's IOREQ feature common To: Oleksandr Cc: Oleksandr Tyshchenko , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Tim Deegan , Julien Grall , xen-devel@lists.xenproject.org References: <1606732298-22107-1-git-send-email-olekstysh@gmail.com> <1606732298-22107-5-git-send-email-olekstysh@gmail.com> <4a82d6f3-6b6c-566a-6ad0-36e22df323fa@gmail.com> From: Jan Beulich Message-ID: <536b5e63-0605-f4d3-e163-dff67ec0422d@suse.com> Date: Tue, 8 Dec 2020 10:21:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <4a82d6f3-6b6c-566a-6ad0-36e22df323fa@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07.12.2020 20:43, Oleksandr wrote: > On 07.12.20 13:41, Jan Beulich wrote: >> On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: >>> @@ -38,42 +37,6 @@ int arch_ioreq_server_get_type_addr(const struct domain *d, >>> uint64_t *addr); >>> void arch_ioreq_domain_init(struct domain *d); >> As already mentioned in an earlier reply: What about these? They >> shouldn't get declared once per arch. If anything, ones that >> want to be inline functions can / should remain in the per-arch >> header. > Don't entirely get a suggestion. Is the suggestion to make "simple" ones > inline? Why not, there are a few ones which probably want to be inline, > such as the following for example: > - arch_ioreq_domain_init > - arch_ioreq_server_destroy > - arch_ioreq_server_destroy_all > - arch_ioreq_server_map_mem_type (probably) Before being able to make a suggestion, I need to have my question answered: Why do the arch_*() declarations live in the arch header? They represent a common interface (between common and arch code) and hence should be declared in exactly one place. It is only at the point where you/we _consider_ making some of them inline that moving those (back) to the arch header may make sense. Albeit even then I'd prefer if only the ones get moved which are expected to be inline for all arch-es. Others would better have the arch header indicate to the common one that no declaration is needed (such that the declaration still remains common for all arch-es using out-of- line functions). Jan