From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH v2] xen: avoid deadlock in xenbus driver Date: Mon, 12 Jun 2017 17:30:16 +0100 Message-ID: <53808967-354d-d432-dbd5-9008872cb618__25482.9632970088$1497285066$gmane$org@arm.com> References: <20170608140342.23833-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSE9-0001UW-O2 for xen-devel@lists.xenproject.org; Mon, 12 Jun 2017 16:30:05 +0000 In-Reply-To: <20170608140342.23833-1-jgross@suse.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: boris.ostrovsky@oracle.com, stable@vger.kernel.org List-Id: xen-devel@lists.xenproject.org SGksCgpPbiAwOC8wNi8xNyAxNTowMywgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBUaGVyZSBoYXMg YmVlbiBhIHJlcG9ydCBhYm91dCBhIGRlYWRsb2NrIGluIHRoZSB4ZW5idXMgZHJpdmVyOgo+IAo+ IFsgIDI0Ny45Nzk0OThdID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQo+IFsgIDI0Ny45ODU2ODhdIFdBUk5JTkc6IHBvc3NpYmxlIGNpcmN1bGFy IGxvY2tpbmcgZGVwZW5kZW5jeSBkZXRlY3RlZAo+IFsgIDI0Ny45OTE4ODJdIDQuMTIuMC1yYzQt MDAwMjItZ2M0YjI1YzAgIzU3NSBOb3QgdGFpbnRlZAo+IFsgIDI0Ny45OTcwNDBdIC0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IFsgIDI0OC4w MDMyMzJdIHhlbmJ1cy85MSBpcyB0cnlpbmcgdG8gYWNxdWlyZSBsb2NrOgo+IFsgIDI0OC4wMDc4 NzVdICAoJnUtPm1zZ2J1ZmZlcl9tdXRleCl7Ky4rLisufSwgYXQ6IFs8ZmZmZjAwMDAwODYzZTkw ND5dCj4geGVuYnVzX2Rldl9xdWV1ZV9yZXBseSsweDNjLzB4MjMwCj4gWyAgMjQ4LjAxNzE2M10K PiBbICAyNDguMDE3MTYzXSBidXQgdGFzayBpcyBhbHJlYWR5IGhvbGRpbmcgbG9jazoKPiBbICAy NDguMDIzMDk2XSAgKHhiX3dyaXRlX211dGV4KXsrLisuLi59LCBhdDogWzxmZmZmMDAwMDA4NjNh OTQwPl0KPiB4ZW5idXNfdGhyZWFkKzB4NWYwLzB4Nzk4Cj4gWyAgMjQ4LjAzMTI2N10KPiBbICAy NDguMDMxMjY3XSB3aGljaCBsb2NrIGFscmVhZHkgZGVwZW5kcyBvbiB0aGUgbmV3IGxvY2suCj4g WyAgMjQ4LjAzMTI2N10KPiBbICAyNDguMDM5NjE1XQo+IFsgIDI0OC4wMzk2MTVdIHRoZSBleGlz dGluZyBkZXBlbmRlbmN5IGNoYWluIChpbiByZXZlcnNlIG9yZGVyKSBpczoKPiBbICAyNDguMDQ3 MTc2XQo+IFsgIDI0OC4wNDcxNzZdIC0+ICMxICh4Yl93cml0ZV9tdXRleCl7Ky4rLi4ufToKPiBb ICAyNDguMDUyOTQzXSAgICAgICAgX19sb2NrX2FjcXVpcmUrMHgxNzI4LzB4MTc3OAo+IFsgIDI0 OC4wNTc0OThdICAgICAgICBsb2NrX2FjcXVpcmUrMHhjNC8weDI4OAo+IFsgIDI0OC4wNjE2MzBd ICAgICAgICBfX211dGV4X2xvY2srMHg4NC8weDg2OAo+IFsgIDI0OC4wNjU3NTVdICAgICAgICBt dXRleF9sb2NrX25lc3RlZCsweDNjLzB4NTAKPiBbICAyNDguMDcwMjI3XSAgICAgICAgeHNfc2Vu ZCsweDE2NC8weDFmOAo+IFsgIDI0OC4wNzQwMTVdICAgICAgICB4ZW5idXNfZGV2X3JlcXVlc3Rf YW5kX3JlcGx5KzB4NmMvMHg4OAo+IFsgIDI0OC4wNzk0MjddICAgICAgICB4ZW5idXNfZmlsZV93 cml0ZSsweDI2MC8weDQyMAo+IFsgIDI0OC4wODQwNzNdICAgICAgICBfX3Zmc193cml0ZSsweDQ4 LzB4MTM4Cj4gWyAgMjQ4LjA4ODExM10gICAgICAgIHZmc193cml0ZSsweGE4LzB4MWI4Cj4gWyAg MjQ4LjA5MTk4M10gICAgICAgIFN5U193cml0ZSsweDU0LzB4YjAKPiBbICAyNDguMDk1NzY4XSAg ICAgICAgZWwwX3N2Y19uYWtlZCsweDI0LzB4MjgKPiBbICAyNDguMDk5ODk3XQo+IFsgIDI0OC4w OTk4OTddIC0+ICMwICgmdS0+bXNnYnVmZmVyX211dGV4KXsrLisuKy59Ogo+IFsgIDI0OC4xMDYw ODhdICAgICAgICBwcmludF9jaXJjdWxhcl9idWcrMHg4MC8weDJlMAo+IFsgIDI0OC4xMTA3MzBd ICAgICAgICBfX2xvY2tfYWNxdWlyZSsweDE3NjgvMHgxNzc4Cj4gWyAgMjQ4LjExNTI4OF0gICAg ICAgIGxvY2tfYWNxdWlyZSsweGM0LzB4Mjg4Cj4gWyAgMjQ4LjExOTQxN10gICAgICAgIF9fbXV0 ZXhfbG9jaysweDg0LzB4ODY4Cj4gWyAgMjQ4LjEyMzU0NV0gICAgICAgIG11dGV4X2xvY2tfbmVz dGVkKzB4M2MvMHg1MAo+IFsgIDI0OC4xMjgwMTZdICAgICAgICB4ZW5idXNfZGV2X3F1ZXVlX3Jl cGx5KzB4M2MvMHgyMzAKPiBbICAyNDguMTMzMDA1XSAgICAgICAgeGVuYnVzX3RocmVhZCsweDc4 OC8weDc5OAo+IFsgIDI0OC4xMzczMDZdICAgICAgICBrdGhyZWFkKzB4MTEwLzB4MTQwCj4gWyAg MjQ4LjE0MTA4N10gICAgICAgIHJldF9mcm9tX2ZvcmsrMHgxMC8weDQwCj4gCj4gSXQgaXMgcmF0 aGVyIGVhc3kgdG8gYXZvaWQgYnkgZHJvcHBpbmcgeGJfd3JpdGVfbXV0ZXggYmVmb3JlIGNhbGxp bmcKPiB4ZW5idXNfZGV2X3F1ZXVlX3JlcGx5KCkuCj4gCj4gRml4ZXM6IGZkOGFhOTA5NWE5NWMw MmRjYzM1NTQwYTI2MzI2N2MyOWI4ZmRhOWQgKCJ4ZW46IG9wdGltaXplIHhlbmJ1cwo+IGRyaXZl ciBmb3IgbXVsdGlwbGUgY29uY3VycmVudCB4ZW5zdG9yZSBhY2Nlc3NlcyIpLgo+IAo+IENjOiA8 c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyA0LjExCj4gUmVwb3J0ZWQtYnk6IEFuZHJlIFByenl3 YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgoKSSBtYW5hZ2VkIHRvIGZpbmQgYSByZWxpYWJs ZSAodGhvdWdoIHdlaXJkKSByZXByb2R1Y2VyIGFuZCBjYW4gY29uZmlybQp0aGF0IHRoaXMgcGF0 Y2ggZml4ZXMgdGhlIGlzc3VlLgpTbyBtYW55IHRoYW5rcyBmb3IgdGhlIHF1aWNrIHdvcmshCgpU ZXN0ZWQtYnk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgoKQ2hlZXJz LApBbmRyZS4KCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NvbW1zLmMgfCAyMSArKysrKysr KysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDExIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2Nv bW1zLmMgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NvbW1zLmMKPiBpbmRleCA4NTZhZGE1 ZDM5YzkuLjViMDgxYTAxNzc5ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5idXMveGVu YnVzX2NvbW1zLmMKPiArKysgYi9kcml2ZXJzL3hlbi94ZW5idXMveGVuYnVzX2NvbW1zLmMKPiBA QCAtMjk5LDE3ICsyOTksNyBAQCBzdGF0aWMgaW50IHByb2Nlc3NfbXNnKHZvaWQpCj4gIAkJbXV0 ZXhfbG9jaygmeGJfd3JpdGVfbXV0ZXgpOwo+ICAJCWxpc3RfZm9yX2VhY2hfZW50cnkocmVxLCAm eHNfcmVwbHlfbGlzdCwgbGlzdCkgewo+ICAJCQlpZiAocmVxLT5tc2cucmVxX2lkID09IHN0YXRl Lm1zZy5yZXFfaWQpIHsKPiAtCQkJCWlmIChyZXEtPnN0YXRlID09IHhiX3JlcV9zdGF0ZV93YWl0 X3JlcGx5KSB7Cj4gLQkJCQkJcmVxLT5tc2cudHlwZSA9IHN0YXRlLm1zZy50eXBlOwo+IC0JCQkJ CXJlcS0+bXNnLmxlbiA9IHN0YXRlLm1zZy5sZW47Cj4gLQkJCQkJcmVxLT5ib2R5ID0gc3RhdGUu Ym9keTsKPiAtCQkJCQlyZXEtPnN0YXRlID0geGJfcmVxX3N0YXRlX2dvdF9yZXBseTsKPiAtCQkJ CQlsaXN0X2RlbCgmcmVxLT5saXN0KTsKPiAtCQkJCQlyZXEtPmNiKHJlcSk7Cj4gLQkJCQl9IGVs c2Ugewo+IC0JCQkJCWxpc3RfZGVsKCZyZXEtPmxpc3QpOwo+IC0JCQkJCWtmcmVlKHJlcSk7Cj4g LQkJCQl9Cj4gKwkJCQlsaXN0X2RlbCgmcmVxLT5saXN0KTsKPiAgCQkJCWVyciA9IDA7Cj4gIAkJ CQlicmVhazsKPiAgCQkJfQo+IEBAIC0zMTcsNiArMzA3LDE1IEBAIHN0YXRpYyBpbnQgcHJvY2Vz c19tc2codm9pZCkKPiAgCQltdXRleF91bmxvY2soJnhiX3dyaXRlX211dGV4KTsKPiAgCQlpZiAo ZXJyKQo+ICAJCQlnb3RvIG91dDsKPiArCj4gKwkJaWYgKHJlcS0+c3RhdGUgPT0geGJfcmVxX3N0 YXRlX3dhaXRfcmVwbHkpIHsKPiArCQkJcmVxLT5tc2cudHlwZSA9IHN0YXRlLm1zZy50eXBlOwo+ ICsJCQlyZXEtPm1zZy5sZW4gPSBzdGF0ZS5tc2cubGVuOwo+ICsJCQlyZXEtPmJvZHkgPSBzdGF0 ZS5ib2R5Owo+ICsJCQlyZXEtPnN0YXRlID0geGJfcmVxX3N0YXRlX2dvdF9yZXBseTsKPiArCQkJ cmVxLT5jYihyZXEpOwo+ICsJCX0gZWxzZQo+ICsJCQlrZnJlZShyZXEpOwo+ICAJfQo+ICAKPiAg CW11dGV4X3VubG9jaygmeHNfcmVzcG9uc2VfbXV0ZXgpOwo+IAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==