From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [libvirt bisection] complete build-amd64-libvirt Date: Fri, 11 Jul 2014 09:06:16 -0600 Message-ID: <53BFFD68.5090305@suse.com> References: <20140711072318.GA21265@aepfle.de> <1405086227.27875.8.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405086227.27875.8.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen.org" , Olaf Hering , xen-devel@lists.xensource.com, keir@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > From 2702cbbffd40384571b39bb6da21d76fc7b8ccd6 Mon Sep 17 00:00:00 2001 > From: Ian Campbell > Date: Fri, 11 Jul 2014 14:38:30 +0100 > Subject: [PATCH] libxl: Correct cast to virDomainDiskDiscard enum. > > This was converted to a typedef in 5a2bd4c9171d "conf: more enum > cleanups in "src/conf/domain_conf.h"" causing: > libxl/libxl_conf.c: In function 'libxlDiskSetDiscard': > libxl/libxl_conf.c:724:19: error: conversion to incomplete type > > Signed-off-by: Ian Campbell > --- > src/libxl/libxl_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c > index 0b4a0b5..f620d47 100644 > --- a/src/libxl/libxl_conf.c > +++ b/src/libxl/libxl_conf.c > @@ -721,7 +721,7 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) > if (!x_disk->readwrite) > return 0; > #if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE) > - switch ((enum virDomainDiskDiscard)discard) { > + switch ((virDomainDiskDiscard)discard) { > case VIR_DOMAIN_DISK_DISCARD_DEFAULT: > case VIR_DOMAIN_DISK_DISCARD_LAST: > break; > Thanks for the fix. I've pushed the patch. Regards, Jim