From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381A6C4361A for ; Fri, 4 Dec 2020 16:30:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF4D622A85 for ; Fri, 4 Dec 2020 16:30:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF4D622A85 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.44950.80402 (Exim 4.92) (envelope-from ) id 1klDxz-0005VW-3E; Fri, 04 Dec 2020 16:29:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 44950.80402; Fri, 04 Dec 2020 16:29:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klDxz-0005VP-03; Fri, 04 Dec 2020 16:29:55 +0000 Received: by outflank-mailman (input) for mailman id 44950; Fri, 04 Dec 2020 16:29:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klDxx-0005VJ-Oo for xen-devel@lists.xenproject.org; Fri, 04 Dec 2020 16:29:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9b67a80c-78cf-4d5d-841d-a0c0931c7e4c; Fri, 04 Dec 2020 16:29:52 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 837E9ACC1; Fri, 4 Dec 2020 16:29:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b67a80c-78cf-4d5d-841d-a0c0931c7e4c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607099391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SL3mwkZxHtAUx3sawZKWGup9Vk1PcbISsUT/Xs/r90c=; b=JcUTC05PV1ie2Y2ULY9lG3A24V4VJcVjejvd2uV+LeflyvfUrk1XS9VyFs0VPcKpnIgaCP v8769GqUr2FEgHfKyzCVUFzUfuU/HHYmkp2LR6H/Nwc0w6Y77HdYJ2RTaknLHJXmEHCUTf oWvUVRoYjJYYeDIvLjvVQaSlkFkarD0= Message-ID: <53c1aa85b4421d90b14f4345fb5cdf77a514a877.camel@suse.com> Subject: Re: [PATCH v2 06/17] xen/cpupool: use ERR_PTR() for returning error cause from cpupool_create() From: Dario Faggioli To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap Date: Fri, 04 Dec 2020 17:29:50 +0100 In-Reply-To: <20201201082128.15239-7-jgross@suse.com> References: <20201201082128.15239-1-jgross@suse.com> <20201201082128.15239-7-jgross@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-GPWP1MuQ5tDtAxoJkZJ2" User-Agent: Evolution 3.38.2 (by Flathub.org) MIME-Version: 1.0 --=-GPWP1MuQ5tDtAxoJkZJ2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: > Instead of a pointer to an error variable as parameter just use > ERR_PTR() to return the cause of an error in cpupool_create(). >=20 Yes... And thanks! Happy to see more of this happening and more of the ad-hoc error handling going away. > This propagates to scheduler_alloc(), too. >=20 > Signed-off-by: Juergen Gross > Reviewed-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-GPWP1MuQ5tDtAxoJkZJ2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl/KY/4ACgkQFkJ4iaW4 c+5bDBAAq5/G7A3RbNQC4aZGOP10aor8sxDTEj17/+1ooAvQbU07DPQKIZhbGoT2 hjI7qnMB8gBStILWaV0HpYNsRj28Xu1zXZDjrVgtwa7z82y8hc5Yqf14eMANmslE YxeVFhDlbZ+orUxz5JoCGNfOSZLP5Ak1OeG4dpK40KmunbToqiwHe55k3NGuTU5n NbznfjMdKrWnRcJJKcOQ629xge6Bkd98dx3M/Wv0JL3VNCsVx3xWY8P+DYAysKrZ hEy47z6oc9AGUCq4AnAisXwAIrfdHeL/VlwKteGb8i2iS0ZAxzc3q1ZeoNr8I0Mx kftWJ159E2E72yBquIfEMj9xB8fpBqDpqLx/uUyGeVF4O4nYO2WUcjUf9hAV9E41 FI88xJga3HMp+Yse+VL2H5wQ3vJPmSsKLuv53C2bMD0vtuC678ZmnJYT9hSAidv4 C7ggl66erCQwQVV9HFx1DIkkuNpZ1fK0xigTJbgQOzfAyjFgB7XSyEMhveh34MJZ zB8AIXERvwaVchj6pMkxOKEn1eQtUKJ1BRQRPv3PgrcVjxO9RJuqbgq0T6XvwoCo F+GcMJV5gdE5/4bMwwubkUjFJ35JlkzxInZuDSJ7ljiEdEk79fB+voEhYApXB8Oh nFH2Ffcaml7XVT5JXFyMGbcTMqGyzOxrUo1D+Jd8P2RpL6I8WME= =n+ut -----END PGP SIGNATURE----- --=-GPWP1MuQ5tDtAxoJkZJ2--