From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45637C43460 for ; Tue, 4 May 2021 11:40:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA308611AE for ; Tue, 4 May 2021 11:40:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA308611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.122125.230325 (Exim 4.92) (envelope-from ) id 1ldtPT-0006Sl-8D; Tue, 04 May 2021 11:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 122125.230325; Tue, 04 May 2021 11:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldtPT-0006Se-4b; Tue, 04 May 2021 11:40:15 +0000 Received: by outflank-mailman (input) for mailman id 122125; Tue, 04 May 2021 11:40:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldtPR-0006SB-Or for xen-devel@lists.xenproject.org; Tue, 04 May 2021 11:40:13 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6007ed61-587b-4a88-95d8-5bb06f376c3e; Tue, 04 May 2021 11:40:12 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8D227B278; Tue, 4 May 2021 11:40:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6007ed61-587b-4a88-95d8-5bb06f376c3e X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1620128411; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/0v17JDLn1s0Zf9Y3DlKqsVYyq+mWO8XcEqT48QLr4=; b=BD6xR3Yp16U41B8j4eOhw1JEtqp73v7aqltUBVe1SMO65+4PheCDJVjzvX78KFVuu7SSCJ oqb4bGj6WU+OxuXCP+w/HNESfrQ/HgYh7XU95H794f2J7dIIxrBfpjpz5NLjrUUTxJpV3A qlJuVon7LWHSUTEkFUFJKOEmVHAQbFM= Subject: Re: [PATCH v3 03/13] libs/guest: allow fetching a specific MSR entry from a cpu policy To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210430155211.3709-1-roger.pau@citrix.com> <20210430155211.3709-4-roger.pau@citrix.com> <273ba6f9-dee9-00db-407b-10325d21afae@suse.com> From: Jan Beulich Message-ID: <54c48a0f-075f-c379-eeb4-60b4439d8907@suse.com> Date: Tue, 4 May 2021 13:40:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04.05.2021 12:56, Roger Pau Monné wrote: > On Mon, May 03, 2021 at 12:41:29PM +0200, Jan Beulich wrote: >> On 30.04.2021 17:52, Roger Pau Monne wrote: >>> --- a/tools/libs/guest/xg_cpuid_x86.c >>> +++ b/tools/libs/guest/xg_cpuid_x86.c >>> @@ -850,3 +850,45 @@ int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t policy, >>> *out = *tmp; >>> return 0; >>> } >>> + >>> +static int compare_entries(const void *l, const void *r) >>> +{ >>> + const xen_msr_entry_t *lhs = l; >>> + const xen_msr_entry_t *rhs = r; >>> + >>> + if ( lhs->idx == rhs->idx ) >>> + return 0; >>> + return lhs->idx < rhs->idx ? -1 : 1; >>> +} >>> + >>> +static xen_msr_entry_t *find_entry(xen_msr_entry_t *entries, >>> + unsigned int nr_entries, unsigned int index) >>> +{ >>> + const xen_msr_entry_t key = { index }; >>> + >>> + return bsearch(&key, entries, nr_entries, sizeof(*entries), compare_entries); >>> +} >> >> Isn't "entries" / "entry" a little too generic a name here, considering >> the CPUID equivalents use "leaves" / "leaf"? (Noticed really while looking >> at patch 7.) > > Would you be fine with naming the function find_msr and leaving the > rest of the parameters names as-is? Yes. But recall I'm not the maintainer of this code anyway. Jan