From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Date: Wed, 17 Jun 2015 10:30:39 +0100 Message-ID: <55813E3F.8030602__5644.73682684383$1434533595$gmane$org@citrix.com> References: <1434481848-26387-1-git-send-email-julien.grall@citrix.com> <1434481848-26387-4-git-send-email-julien.grall@citrix.com> <1434533143.13744.273.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z59gZ-0003PO-KT for xen-devel@lists.xenproject.org; Wed, 17 Jun 2015 09:31:07 +0000 In-Reply-To: <1434533143.13744.273.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Wei Liu , linux-kernel@vger.kernel.org, netdev@vger.kernel.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 17/06/2015 10:25, Ian Campbell wrote: > On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote: >> Append 0x to all %x in order to avoid while reading when there is other >> decimal value in the log. >> >> Also replace some of the hexadecimal print to decimal to uniformize the >> format with netfront. >> >> Signed-off-by: Julien Grall >> Cc: Wei Liu >> Cc: Ian Campbell >> Cc: netdev@vger.kernel.org > > You meant s/Append/Prepend/, nonetheless: I noticed a missing word after "avoid" in the commit message too. I will update to: "Prepend 0x to all %x in order to avoid confusion while reading when there is other decimal value in the log. [...]". > > Acked-by: Ian Campbell I see different opinion on whether using 0x% or %#. As I plan to resend a version with the commit message update, shall I use %#? Regards, -- Julien Grall